Review main Merged

80264[BUGFIX] Fix return type of GU::getMaxUploadFileSize

Oliver Klee CR +2 V +2 Easy +12 −8 updated 07/31/23, 11:18

Commit message

This method promises to return an int, but actually returns a float.

Also add a regression test.

> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 810

  1. Oliver Klee uploaded patch set 1 07/31/23, 08:39

  2. core-ci voted on patch set 1 V +1 07/31/23, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44783

  3. Christian Kuhn commented on patch set 1 07/31/23, 09:30

    GeneralUtility.php:1956

    ": int" along the way? The 'isInt' assertion in unit test could also be skipped.
  4. Christian Kuhn commented on patch set 1 07/31/23, 09:44

    GeneralUtility.php:1954

    let's write "The maximum size of uploads that are allowed in KiB (divider 1024)"
  5. Christian Kuhn uploaded patch set 2 V +1 07/31/23, 10:23

  6. Christian Kuhn commented on patch set 2 07/31/23, 10:24

    GeneralUtility.php:1954 Reply

    Done

    GeneralUtility.php:1956 Reply

    v11 will not get this return type added, though.
  7. Christian Kuhn voted on patch set 2 V +1 CR +1 07/31/23, 10:31

  8. core-ci voted on patch set 2 V +1 07/31/23, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44795

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 07/31/23, 11:18

  10. Christian Kuhn merged patch set 3 07/31/23, 11:18