Review 11.5 Merged

80273[BUGFIX] Fix return type of GU::getMaxUploadFileSize

Christian Kuhn CR +2 V +2 Easy +12 −7 updated 07/31/23, 11:19

Commit message

This method promises to return an int, but actually returns a float.

Also add a regression test.

> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Christian Kuhn uploaded patch set 1 07/31/23, 10:29

  2. core-ci voted on patch set 1 V +1 07/31/23, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44798

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 07/31/23, 11:19

  4. Christian Kuhn merged patch set 2 07/31/23, 11:19