Review 11.5 Merged

80280[BUGFIX] Stabilize AbstractDomainObject _isDirty check

Nikita Hovratov CR +2 V +2 Easy +13 −2 updated 09/07/23, 20:12

Commit message

Accessing static properties as non-static has always
triggered a notice in PHP. However, since PHP 8.0
accessing undefined properties (which always comes with
the former notice) is now a warning. This will be
caught by the error handler in debug mode.

To fix this, the more robust _getProperty method is
backported from #100120 and used in the _isDirty method.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2