Review main Merged

80289[TASK] Upgrade to Lit v3

Benjamin Franzke CR +2 V +2 Hard +173 −107 updated 10/31/23, 12:05

Commit message

Lit v3 is a new major release and contains breaking changes, but they do
not affect us: It mainly drops IE11 support (which we already dropped)
and switches to ES2021 modules (which we already use as well):
https://lit.dev/blog/2023-10-10-lit-3.0/#breaking-changes

npm install --save \
    lit@^3.0 \
    lit-html@^3.0 \
    lit-element@^4.0 \
    @lit/reactive-element@^2.0
npm run build

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 44

Show 24 more files

Review log 1925

  1. Benjamin Franzke uploaded patch set 1 07/31/23, 19:32

  2. core-ci voted on patch set 1 V +1 07/31/23, 19:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44841

  3. Benjamin Franzke marked it work in progress 08/01/23, 06:21

  4. Benjamin Franzke uploaded patch set 2 V +1 10/11/23, 03:18

  5. core-ci voted on patch set 2 V +1 10/11/23, 03:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47671

  6. Benjamin Franzke rebased onto patch set 3 V +1 10/27/23, 13:52

  7. core-ci voted on patch set 3 V +1 10/27/23, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48291

  8. Benjamin Franzke updated the commit message in patch set 4 V +1 10/30/23, 13:29

  9. core-ci voted on patch set 4 V +1 10/30/23, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48354

  10. Benni Mack voted on patch set 4 CR +1 10/30/23, 15:03

  11. Andreas Kienast commented on patch set 4 10/30/23, 15:05

    draggable-resizable-element.ts:178

    Why isn't this necessary on any other Lit element we built?
  12. Andreas Kienast commented on patch set 4 10/30/23, 15:07

    Ah, lit 3.0.1 was released recently: https://github.com/lit/lit/releases/tag/lit%403.0.1 However, not sure if this is important to us.
  13. Benjamin Franzke uploaded patch set 5 CR +1 V +1 10/30/23, 15:24

  14. Benjamin Franzke commented on patch set 5 10/30/23, 15:29

    Reply

    Ack, I missed to check again, updated now.

    draggable-resizable-element.ts:178 Reply

    Basically because we usually define `HTMLElement` instead of `Element`, and upstream now defines: ``` protected createRenderRoot(): HTMLElement | DocumentFragment ``` So `ShadowRoot` is still allowed, as it's a subclass of `DocumentFragment`, but `Element` is disallowed, as that's a super class instead of a subclass of the allowed return types.
  15. core-ci voted on patch set 5 V +1 10/30/23, 15:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48362

  16. Benni Mack voted on patch set 5 V +1 CR +1 10/30/23, 15:52

  17. Andreas Kienast voted on patch set 5 V +1 CR +1 10/31/23, 09:04

  18. Benjamin Franzke commented on patch set 5 CR -1 10/31/23, 09:50

    Sorry, something is wrong, `@lit/reactive-element` wasn't updated properly due to `select-pure` dependency. Will fix.
  19. Benjamin Franzke uploaded patch set 6 CR +1 V +1 10/31/23, 10:00

  20. core-ci voted on patch set 6 V +1 10/31/23, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48389

  21. Benni Mack voted on patch set 6 V +1 CR +1 10/31/23, 11:06

  22. Andreas Kienast voted on patch set 6 V +1 CR +1 10/31/23, 11:31

  23. Andreas Kienast commented on patch set 6 10/31/23, 11:31

    draggable-resizable-element.ts:178 Reply

    Done
  24. Benjamin Franzke voted on patch set 6 V +2 CR +2 10/31/23, 12:05

  25. Benjamin Franzke merged patch set 7 10/31/23, 12:05