80289[TASK] Upgrade to Lit v3
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 44
- Build/Sources/TypeScript/backend/element/draggable-resizable-element.ts3+1 −1
- Build/Sources/TypeScript/backend/notification.ts+7 −7
- Build/package-lock.json+111 −26
- Build/package.json+4 −4
- typo3/sysext/backend/Resources/Public/JavaScript/notification.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/decorators/base.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/decorators/custom-element.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/decorators/event-options.js+2 −2
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/decorators/property.js+2 −2
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/decorators/query-all.js+3 −2
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/decorators/query-assigned-elements.js+2 −2
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/decorators/query-assigned-nodes.js+2 −2
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/decorators/query-async.js+2 −2
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/decorators/query.js+2 −2
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/decorators/state.js+2 −2
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/css-tag.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/decorators.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/reactive-element.js+2 −2
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/experimental-hydrate-support.jsdeleted+0 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/experimental-hydrate.jsdeleted+0 −1
Show 24 more files
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/decorators.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/experimental-hydrate-support.jsdeleted+0 −7
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/index.js+1 −6
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/lit-element.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/cache.js+2 −2
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/choose.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/class-map.js+2 −2
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/guard.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/if-defined.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/private-async-helpers.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/range.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/ref.js+2 −2
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/repeat.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/style-map.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/template-content.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/unsafe-html.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/until.js+2 −2
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/when.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/async-directive.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directive-helpers.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/experimental-hydrate.jsdeleted+0 −6
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/lit-html.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/private-ssr-support.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/static.js+1 −1
Review log 1925
-
Benjamin Franzke uploaded patch set 1 07/31/23, 19:32
-
core-ci voted on patch set 1 V +1 07/31/23, 19:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44841
-
Benjamin Franzke marked it work in progress 08/01/23, 06:21
-
Benjamin Franzke uploaded patch set 2
V +110/11/23, 03:18 -
core-ci voted on patch set 2 V +1 10/11/23, 03:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47671
-
Benjamin Franzke rebased onto patch set 3
V +110/27/23, 13:52 -
core-ci voted on patch set 3 V +1 10/27/23, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48291
-
Benjamin Franzke updated the commit message in patch set 4
V +110/30/23, 13:29 -
core-ci voted on patch set 4 V +1 10/30/23, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48354
-
Benni Mack voted on patch set 4 CR +1 10/30/23, 15:03
-
Andreas Kienast commented on patch set 4 10/30/23, 15:05
-
Andreas Kienast commented on patch set 4 10/30/23, 15:07
Ah, lit 3.0.1 was released recently: https://github.com/lit/lit/releases/tag/lit%403.0.1 However, not sure if this is important to us. -
Benjamin Franzke uploaded patch set 5
CR +1V +110/30/23, 15:24 -
Benjamin Franzke commented on patch set 5 10/30/23, 15:29
Reply
Ack, I missed to check again, updated now.draggable-resizable-element.ts:178ReplyBasically because we usually define `HTMLElement` instead of `Element`, and upstream now defines: ``` protected createRenderRoot(): HTMLElement | DocumentFragment ``` So `ShadowRoot` is still allowed, as it's a subclass of `DocumentFragment`, but `Element` is disallowed, as that's a super class instead of a subclass of the allowed return types. -
core-ci voted on patch set 5 V +1 10/30/23, 15:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48362
-
Benni Mack voted on patch set 5 V +1 CR +1 10/30/23, 15:52
-
Andreas Kienast voted on patch set 5 V +1 CR +1 10/31/23, 09:04
-
Benjamin Franzke commented on patch set 5 CR -1 10/31/23, 09:50
Sorry, something is wrong, `@lit/reactive-element` wasn't updated properly due to `select-pure` dependency. Will fix. -
Benjamin Franzke uploaded patch set 6
CR +1V +110/31/23, 10:00 -
core-ci voted on patch set 6 V +1 10/31/23, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48389
-
Benni Mack voted on patch set 6 V +1 CR +1 10/31/23, 11:06
-
Andreas Kienast voted on patch set 6 V +1 CR +1 10/31/23, 11:31
-
Andreas Kienast commented on patch set 6 10/31/23, 11:31
draggable-resizable-element.ts:178ReplyDone -
Benjamin Franzke voted on patch set 6 V +2 CR +2 10/31/23, 12:05
-
Benjamin Franzke merged patch set 7 10/31/23, 12:05
draggable-resizable-element.ts:178