Review main Merged Breaking

80292[!!!][TASK] Remove `immediate` flag in `DebounceEvent`

Andreas Kienast CR +2 V +2 Normal +56 −20 updated 08/03/23, 12:06

Commit message

With the introduction in TYPO3 v10, the `DebounceEvent` module had the
possibility to shift the event handler execution to the beginning of
the debounce sequence, enabled via the optional `immediate` parameter.

The parameter is unused in TYPO3 and using this feature has a negative
impact on UX. If used, the event handler is directly executed and the
user has to wait a specific time after the last event was triggered,
before any further execution is possible.

The flag `immediate` has been therefore removed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1013

  1. Andreas Kienast uploaded patch set 1 08/01/23, 10:14

  2. Andreas Kienast updated the commit message in patch set 2 08/01/23, 10:15

  3. Benni Mack commented on patch set 2 08/01/23, 10:18

    debounce-event.ts:22

    should we get rid of the trailing comma "number 250," ?
  4. Andreas Kienast commented on patch set 2 08/01/23, 10:21

    debounce-event.ts:22 Reply

    Thanks, I overlooked that.
  5. Andreas Kienast uploaded patch set 3 08/01/23, 10:21

  6. core-ci voted on patch set 2 V +1 08/01/23, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44854

  7. core-ci voted on patch set 1 V +1 08/01/23, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44853

  8. core-ci voted on patch set 3 V +1 08/01/23, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44855

  9. Benjamin Franzke voted on patch set 3 CR +1 08/02/23, 15:57

  10. Benjamin Franzke voted on patch set 3 V +1 08/02/23, 16:04

  11. Christian Kuhn voted on patch set 3 V +1 CR +1 08/03/23, 12:05

  12. Andreas Kienast voted on patch set 3 V +2 CR +2 08/03/23, 12:06

  13. Andreas Kienast merged patch set 4 08/03/23, 12:06