Review main Merged

80312[BUGFIX] Use `Utility.trimExplode()` in FormEngine validation

Andreas Kienast CR +2 V +2 Normal +9 −42 updated 08/04/23, 09:15

Commit message

The module `@typo3/backend/form-engine-validation` had an own
implemention of the `trimExplode()` functionality. The method is now
removed and any usage is replaced with the existing
`Utility.trimExplode()` method.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Jörg Bösche +1
    • Henning Liebe +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 67

  1. Andreas Kienast uploaded patch set 1 08/03/23, 16:22

  2. core-ci voted on patch set 1 V +1 08/03/23, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44931

  3. Jörg Bösche voted on patch set 1 CR +1 08/03/23, 19:15

  4. Oliver Klee voted on patch set 1 V +1 CR +1 08/03/23, 19:39

  5. Henning Liebe voted on patch set 1 CR +1 08/03/23, 19:45

  6. Anja Leichsenring voted on patch set 1 V +2 CR +2 08/04/23, 09:15

  7. Anja Leichsenring merged patch set 2 08/04/23, 09:15