Review main Merged

80313[TASK] Run PHP8.3 functional tests

Stefan Bürk CR +2 V +2 Normal +106 −6 updated 08/04/23, 13:02

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Stefan Bürk uploaded patch set 1 08/03/23, 17:41

  2. core-ci voted on patch set 1 V +1 08/03/23, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44934

  3. Stefan Bürk uploaded patch set 2 V +1 08/03/23, 17:51

  4. core-ci voted on patch set 2 V +1 08/03/23, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44935

  5. Oliver Klee commented on patch set 2 08/03/23, 19:58

    functional.yml:21

    Shouldn't we add 8.3 in this configuration file instead of replacing 8.2 with 8.3? Or do we intentionally only test with the lowest and the highest allowed PHP version?
  6. Anja Leichsenring commented on patch set 2 V +1 CR +1 08/04/23, 11:35

    functional.yml:21 Reply

    It's on purpose. Pre-merge needs to be quick, full coverage happens in nightly run. Besides, this is the configuration file, no other one is available.
  7. Stefan Bürk commented on patch set 2 08/04/23, 12:14

    functional.yml:21 Reply

    Done
  8. Christian Kuhn voted on patch set 2 V +2 CR +2 08/04/23, 13:02

  9. Christian Kuhn merged patch set 3 08/04/23, 13:02