Review main Merged

80319[BUGFIX] Make GeneralUtility::getFilesInDir() correctly check extensions

Christian Spoo CR +2 V +2 Easy +15 −1 updated 08/03/23, 19:31

Commit message

Invoke `str_ends_with` on lowercased filesystem entries in order to check
for allowed extensions. This is more stable than `substr`ing the
comma-separated list of extensions.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Andreas Kienast +1

Issues 1

Files 2

Review log 1520

  1. Christian Spoo uploaded patch set 1 08/03/23, 19:01

  2. Oli Bartsch commented on patch set 1 08/03/23, 19:07

    GeneralUtility.php:1803

    Patch works! Could we just omit this variable assignment?
  3. Christian Spoo uploaded patch set 2 08/03/23, 19:10

  4. Christian Spoo commented on patch set 2 08/03/23, 19:16

    GeneralUtility.php:1803 Reply

    Done
  5. Oliver Klee commented on patch set 2 08/03/23, 19:16

    GeneralUtility.php:1803 Reply

    Done
  6. Oliver Klee commented on patch set 2 CR -1 08/03/23, 19:17

    on it

    GeneralUtilityTest.php:2650

    Usually, we don't put the ticket ID next to the tests.
  7. core-ci voted on patch set 1 V +1 08/03/23, 19:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44946

  8. Oliver Klee uploaded patch set 3 CR -1 08/03/23, 19:18

  9. Christian Spoo updated the commit message in patch set 4 08/03/23, 19:19

  10. Oliver Klee commented on patch set 3 V +1 CR +1 08/03/23, 19:19

    Neat!

    GeneralUtilityTest.php:2650 Reply

    Done
  11. Christian Spoo commented on patch set 2 08/03/23, 19:19

    GeneralUtilityTest.php:2650 Reply

    Ack
  12. core-ci voted on patch set 2 V +1 08/03/23, 19:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44949

  13. Oliver Klee updated the commit message in patch set 5 08/03/23, 19:22

  14. Oliver Klee voted on patch set 5 V +1 CR +1 08/03/23, 19:23

  15. Andreas Kienast voted on patch set 5 V +1 CR +1 08/03/23, 19:26

  16. Oli Bartsch voted on patch set 5 V +2 CR +2 08/03/23, 19:26

  17. Oli Bartsch merged patch set 6 08/03/23, 19:26

  18. core-ci voted on patch set 4 V +1 08/03/23, 19:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44952

  19. core-ci voted on patch set 3 V +1 08/03/23, 19:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44951

  20. core-ci voted on patch set 5 V +1 08/03/23, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44953