Review main Abandoned

80326[BUGFIX] Respect original limit and offset when paginating QueryResults

Christian Spoo CR 0 V 0 Normal +66 −2 updated 03/28/25, 12:28

Commit message

We should respect limit and offset of an underlying `QueryResult` when
calculating limit and offset for the pagination window. Thus, add the
pagination offset to the original offset and reduce the pagination's
limit if the original one is lower.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 711

  1. Christian Spoo uploaded patch set 1 08/03/23, 20:25

  2. Christian Spoo updated the commit message in patch set 2 08/03/23, 20:28

  3. Christian Spoo updated the commit message in patch set 3 08/03/23, 20:37

  4. core-ci voted on patch set 3 V -1 08/03/23, 20:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44972

  5. Christian Spoo uploaded patch set 4 V -1 08/03/23, 20:58

  6. core-ci voted on patch set 2 V -1 08/03/23, 20:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44971

  7. core-ci voted on patch set 1 V -1 08/03/23, 20:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44970

  8. core-ci voted on patch set 4 V +1 08/03/23, 21:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44979

  9. Stefan Bürk commented on patch set 4 CR -1 08/04/23, 09:33

    Unresolved

    Thanks for this change. This change is basically the same change as https://review.typo3.org/c/Packages/TYPO3.CMS/+/72817 I already commentend there in length why I would say that this is not the correct way. Granted, that some may expect the behaviour tried to archieve. Other developer expect exactly the opposite. I practice and other frameworks, database query based paginators are in charge to control the limit and offset and does not repsect the original set values from the passed query object. As already documented in the other change, this needs to be a dedicated paginator or at least configurable keeping the current state as the default. There was no real further decision making or discussion in the other change - so I will re-apply the -1 on this. We need to really decide what the correct expection would be, beside some edge case expectations. For me, this is not a bugfix because the Paginator is working as it can be expected to work. I linked the issues already. For details see the lengthy comment in the other change.
  10. Benni Mack updated the commit message in patch set 5 CR -1 V +1 10/18/24, 14:10

  11. Benni Mack abandoned the change 03/28/25, 12:28

    abandoning this change (like the other one) as there was no feedback after 18 months. Can be restored once somebody wants to pick it up.