80328[BUGFIX] Remove GU::fixPermissionsSetsGroup() test
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
-
Verified V +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1013
-
Tobias Liebig uploaded patch set 1 08/03/23, 20:53
-
Oliver Wand voted on patch set 1 CR +1 08/03/23, 20:53
-
core-ci voted on patch set 1 V +1 08/03/23, 21:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44977
-
Stefan Bürk updated the commit message in patch set 2
CR +1V +108/03/23, 21:07 -
core-ci voted on patch set 2 V +1 08/03/23, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44990
-
Oliver Klee commented on patch set 2 08/03/23, 21:29
Maybe we can add a sentence to the commit message explaining why we’re dropping this test. -
Stefan Bürk commented on patch set 2 CR -1 08/03/23, 22:04
That's not the only hurting test. We need to recheck with Frank and others to identify more tests. For example: - fixPermissionReturnsOkStatusIfPermissionCanBeFixedAndSetsPermissionToCorrectValue e.g: ``` Failed asserting that two strings are identical. --- Expected +++ Actual @@ @@ -'2770' +'0770' ```Reply
Ack. Basically because they make headache on some macs and that not for the first time. But there are more of them. -
Christian Kuhn uploaded patch set 3
CR -1V +108/04/23, 08:27 -
core-ci voted on patch set 3 V +1 08/04/23, 08:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45027
-
Christian Kuhn commented on patch set 3 08/04/23, 08:39
Reply
Done -
Anja Leichsenring voted on patch set 3 V +1 CR +1 08/04/23, 08:44
-
Christian Kuhn voted on patch set 3 V +2 CR +2 08/04/23, 09:32
-
Christian Kuhn merged patch set 4 08/04/23, 09:32