Review main Merged

80328[BUGFIX] Remove GU::fixPermissionsSetsGroup() test

Tobias Liebig CR +2 V +2 Easy +0 −23 updated 08/04/23, 09:32

Commit message

This test checks lowlevel things like usergroup to
be changed by GeneralUtility::fixPermissions().
Various tests in this area have been disabled on
Windows already. They are problematic in macOS driven
docker as well since macOS heavily messes around with
access rights.
We give up on this now, and reduce the details test
checks of GeneralUtility::fixPermissions() a bit by
removing that test.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Tobias Liebig uploaded patch set 1 08/03/23, 20:53

  2. Oliver Wand voted on patch set 1 CR +1 08/03/23, 20:53

  3. core-ci voted on patch set 1 V +1 08/03/23, 21:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44977

  4. Stefan Bürk updated the commit message in patch set 2 CR +1 V +1 08/03/23, 21:07

  5. core-ci voted on patch set 2 V +1 08/03/23, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44990

  6. Oliver Klee commented on patch set 2 08/03/23, 21:29

    Maybe we can add a sentence to the commit message explaining why we’re dropping this test.
  7. Stefan Bürk commented on patch set 2 CR -1 08/03/23, 22:04

    That's not the only hurting test. We need to recheck with Frank and others to identify more tests. For example: - fixPermissionReturnsOkStatusIfPermissionCanBeFixedAndSetsPermissionToCorrectValue e.g: ``` Failed asserting that two strings are identical. --- Expected +++ Actual @@ @@ -'2770' +'0770' ```

    Reply

    Ack. Basically because they make headache on some macs and that not for the first time. But there are more of them.
  8. Christian Kuhn uploaded patch set 3 CR -1 V +1 08/04/23, 08:27

  9. core-ci voted on patch set 3 V +1 08/04/23, 08:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45027

  10. Christian Kuhn commented on patch set 3 08/04/23, 08:39

    Reply

    Done
  11. Anja Leichsenring voted on patch set 3 V +1 CR +1 08/04/23, 08:44

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 08/04/23, 09:32

  13. Christian Kuhn merged patch set 4 08/04/23, 09:32