Review main Merged

80378[BUGFIX] Properly set memcache/memcached in cache backend

Christian Spoo CR +2 V +2 Easy +1 −3 updated 08/04/23, 10:18

Commit message

parent::__construct() of MemcachedBackend calls
setCompression() which determines compression based
on state of $this->usePeclModule. This property needs
to be set before parent::__construct() is called.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Christian Spoo uploaded patch set 1 08/03/23, 21:52

  2. core-ci voted on patch set 1 V +1 08/03/23, 22:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45007

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 08/04/23, 08:27

  4. Christian Kuhn uploaded patch set 2 CR +1 V +1 08/04/23, 09:44

  5. core-ci voted on patch set 2 V +1 08/04/23, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45040

  6. Christian Kuhn voted on patch set 1 CR -1 08/04/23, 09:57

  7. Christian Kuhn uploaded patch set 3 V +1 08/04/23, 10:03

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 08/04/23, 10:04

  9. Stefan Bürk voted on patch set 3 V +1 CR +1 08/04/23, 10:06

  10. core-ci voted on patch set 3 V +1 08/04/23, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45043

  11. Stefan Bürk voted on patch set 3 V +2 CR +2 08/04/23, 10:18

  12. Stefan Bürk merged patch set 4 08/04/23, 10:18