80386[FEATURE] Improve event listener registration
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 2
Files 9
- typo3/sysext/backend/Classes/EventListener/FailedLoginAttemptNotification.php+4 −1
- typo3/sysext/backend/Configuration/Services.yaml+0 −7
- typo3/sysext/core/Classes/Attribute/AsEventListener.php+2 −2
- typo3/sysext/core/Classes/DependencyInjection/ListenerProviderPass.php+2 −1
- typo3/sysext/core/Classes/EventDispatcher/ListenerProvider.php+2 −2
- typo3/sysext/core/Configuration/Services.php2+2 −2
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-101544-IntroducePHPAttributeToAutoconfigureEventListeners.rst2+40 −13
- typo3/sysext/core/Tests/Unit/DependencyInjection/ListenerProviderPassTest.php+3 −3
- typo3/sysext/core/Tests/Unit/EventDispatcher/ListenerProviderTest.php+2 −2
Review log 1215
-
Oli Bartsch uploaded patch set 1 08/04/23, 09:52
-
core-ci voted on patch set 1 V -1 08/04/23, 09:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45042
-
Sascha Nowak commented on patch set 1 CR -1 08/04/23, 10:15
Thanks for making my change even better. I added some comments to your PR.Services.php:25The variable $reflector is unused.Feature-101544-IntroducePHPAttributeToAutoconfigureEventListeners.rst:21Could you mention, that the serviceName is used as identifier if not set, as this could be relevant for execution sequence -
Oli Bartsch uploaded patch set 2
CR -1V -108/04/23, 11:24 -
Oli Bartsch commented on patch set 2 08/04/23, 11:25
Services.php:25ReplyThis is by intention. Otherwise method target does not work.Feature-101544-IntroducePHPAttributeToAutoconfigureEventListeners.rst:21ReplyThis is the behaviour for the tags and not dedicated to the new PHP Attribute. However, I added the information here anyways. -
Sascha Nowak voted on patch set 2 V +1 08/04/23, 11:31
-
core-ci voted on patch set 2 V +1 08/04/23, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45049
-
Andreas Kienast voted on patch set 2 CR +1 08/04/23, 12:26
-
Andreas Kienast voted on patch set 2 V +1 08/04/23, 13:36
-
Benjamin Franzke uploaded patch set 3
CR +1V +108/04/23, 13:42 -
core-ci voted on patch set 3 V +1 08/04/23, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45072
-
Andreas Kienast voted on patch set 3 V +1 CR +1 08/04/23, 14:16
-
Oli Bartsch voted on patch set 3 V +2 CR +2 08/04/23, 14:18
-
Oli Bartsch merged patch set 4 08/04/23, 14:18
-
Benni Mack voted on patch set 4 CR +1 08/04/23, 16:18