Review main Merged

80403[TASK] EXT:install: Migrate `InfoBox` and `FlashMessage` to Lit

Andreas Kienast CR +2 V +2 Hard +198 −191 updated 08/10/23, 05:58

Commit message

In the effort of removing jQuery from the Install Tool, this patch
migrates the `InfoBox` and `FlashMessage` components to custom Lit
elements.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 31

Show 11 more files

Review log 1013

  1. Andreas Kienast uploaded patch set 1 08/05/23, 09:31

  2. Andreas Kienast uploaded patch set 2 08/05/23, 09:33

  3. core-ci voted on patch set 1 V +1 08/05/23, 09:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45101

  4. core-ci voted on patch set 2 V +1 08/05/23, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45102

  5. Andreas Nedbal commented on patch set 2 CR -1 08/09/23, 09:16

    The code works, but the element creation is a lot of repetition imho. The API to create infoboxes/flashmessages could be simplified with a static `create` method that returns the HTML element instead of having to assemble it in-place, so... ``` const infobox = document.createElement('typo3-install-infobox'); infobox.severity = Severity.ok; infobox.subject = 'Database schema is up to date. Good job!'; outputContainer.append(infobox); ``` could turn into ``` const infobox = InfoBox.create(Severity.ok, 'Database schema is up to date. Good job!'); outputContainer.append(infobox); ``` This would also be closer to the previous `InfoBox.render` calls.
  6. Andreas Kienast commented on patch set 2 08/09/23, 09:23

    Reply

    Thanks, will check this out.
  7. Andreas Kienast uploaded patch set 3 CR -1 V +1 08/09/23, 10:41

  8. core-ci voted on patch set 3 V +1 08/09/23, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45276

  9. Andreas Kienast commented on patch set 3 08/09/23, 10:57

    Reply

    Done
  10. Andreas Nedbal voted on patch set 3 V +1 CR +1 08/09/23, 10:58

  11. Christian Kuhn voted on patch set 3 V +1 CR +1 08/10/23, 05:57

  12. Andreas Kienast voted on patch set 3 V +2 CR +2 08/10/23, 05:58

  13. Andreas Kienast merged patch set 4 08/10/23, 05:58