80403[TASK] EXT:install: Migrate `InfoBox` and `FlashMessage` to Lit
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Andreas Nedbal +1
- Christian Kuhn +1
-
Verified V +2 Done
- Andreas Kienast +2
- Andreas Nedbal +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 31
- Build/Sources/TypeScript/install/module/environment/environment-check.ts+2 −5
- Build/Sources/TypeScript/install/module/environment/folder-structure.ts+8 −17
- Build/Sources/TypeScript/install/module/environment/image-processing.ts+3 −3
- Build/Sources/TypeScript/install/module/environment/mail-test.ts+3 −6
- Build/Sources/TypeScript/install/module/maintenance/database-analyzer.ts+3 −4
- Build/Sources/TypeScript/install/module/maintenance/language-packs.ts+15 −22
- Build/Sources/TypeScript/install/module/upgrade/core-update.ts+3 −6
- Build/Sources/TypeScript/install/module/upgrade/extension-compat-tester.ts+7 −14
- Build/Sources/TypeScript/install/module/upgrade/tca-ext-tables-check.ts+9 −14
- Build/Sources/TypeScript/install/module/upgrade/tca-migrations-check.ts+14 −8
- Build/Sources/TypeScript/install/module/upgrade/upgrade-wizards.ts+9 −17
- Build/Sources/TypeScript/install/renderable/flash-message.ts+38 −14
- Build/Sources/TypeScript/install/renderable/info-box.ts+38 −19
- Build/Sources/TypeScript/install/renderable/progress-bar.ts+0 −1
- Build/Sources/TypeScript/install/installer.ts+8 −16
- Build/Sources/TypeScript/install/router.ts+13 −10
- typo3/sysext/install/Resources/Public/JavaScript/module/environment/environment-check.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/environment/folder-structure.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/environment/image-processing.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/environment/mail-test.js+1 −1
Show 11 more files
- typo3/sysext/install/Resources/Public/JavaScript/module/maintenance/database-analyzer.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/maintenance/language-packs.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/core-update.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/extension-compat-tester.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/tca-ext-tables-check.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/tca-migrations-check.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/upgrade-wizards.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/renderable/flash-message.js+6 −1
- typo3/sysext/install/Resources/Public/JavaScript/renderable/info-box.js+6 −1
- typo3/sysext/install/Resources/Public/JavaScript/installer.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/router.js+1 −1
Review log 1013
-
Andreas Kienast uploaded patch set 1 08/05/23, 09:31
-
Andreas Kienast uploaded patch set 2 08/05/23, 09:33
-
core-ci voted on patch set 1 V +1 08/05/23, 09:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45101
-
core-ci voted on patch set 2 V +1 08/05/23, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45102
-
Andreas Nedbal commented on patch set 2 CR -1 08/09/23, 09:16
The code works, but the element creation is a lot of repetition imho. The API to create infoboxes/flashmessages could be simplified with a static `create` method that returns the HTML element instead of having to assemble it in-place, so... ``` const infobox = document.createElement('typo3-install-infobox'); infobox.severity = Severity.ok; infobox.subject = 'Database schema is up to date. Good job!'; outputContainer.append(infobox); ``` could turn into ``` const infobox = InfoBox.create(Severity.ok, 'Database schema is up to date. Good job!'); outputContainer.append(infobox); ``` This would also be closer to the previous `InfoBox.render` calls. -
Andreas Kienast commented on patch set 2 08/09/23, 09:23
Reply
Thanks, will check this out. -
Andreas Kienast uploaded patch set 3
CR -1V +108/09/23, 10:41 -
core-ci voted on patch set 3 V +1 08/09/23, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45276
-
Andreas Kienast commented on patch set 3 08/09/23, 10:57
Reply
Done -
Andreas Nedbal voted on patch set 3 V +1 CR +1 08/09/23, 10:58
-
Christian Kuhn voted on patch set 3 V +1 CR +1 08/10/23, 05:57
-
Andreas Kienast voted on patch set 3 V +2 CR +2 08/10/23, 05:58
-
Andreas Kienast merged patch set 4 08/10/23, 05:58