Review main Abandoned

80405[BUGFIX] Remove BE_USER PAGE_SHOW check for frontend access

Gerrit Mohrmann CR 0 V 0 Easy +0 −22 updated 03/27/25, 11:37

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 1

Review log 1823

  1. Gerrit Mohrmann uploaded patch set 1 08/05/23, 10:22

  2. core-ci voted on patch set 1 V -1 08/05/23, 10:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45104

  3. Gerrit Mohrmann uploaded patch set 2 V -1 08/05/23, 10:33

  4. Gerrit Mohrmann commented on patch set 1 08/05/23, 10:35

    Maybe thats not the right solution to solve this. The site should only be blocked if the frontend is not accessible and the be_user have not the show rights. Only check for the be_user is not right in my opinion
  5. core-ci voted on patch set 2 V +1 08/05/23, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45105

  6. Benni Mack updated the commit message in patch set 3 V +1 10/18/24, 14:11

  7. Gerrit Mohrmann uploaded patch set 4 10/31/24, 15:51

  8. core-ci voted on patch set 4 V +1 10/31/24, 15:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68932

  9. Sybille Peters commented on patch set 4 01/28/25, 10:35

    fyi, I tested that this patch also fixes my issue https://forge.typo3.org/issues/104629 as described in description (with adminpanel active, in adminpanel settings "Show hidden pages" is on, BE user does not have acces to page and opens the page via link, results in 403).
  10. Georg Ringer updated the commit message in patch set 5 V +1 03/05/25, 12:17

  11. Georg Ringer voted on patch set 5 CR +1 V +1 03/05/25, 12:17

  12. core-ci voted on patch set 5 V -1 03/05/25, 12:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75161

  13. Georg Ringer rebased onto patch set 6 CR +1 V +1 03/06/25, 15:52

  14. core-ci voted on patch set 6 V +1 03/06/25, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75230

  15. Georg Ringer voted on patch set 6 CR +1 V +1 03/06/25, 16:03

  16. Sybille Peters voted on patch set 6 V +1 03/06/25, 17:30

  17. Benni Mack commented on patch set 6 CR -2 03/24/25, 20:11

    will verify this tomorrow!
  18. Benni Mack commented on patch set 6 CR -1 03/25/25, 22:10

    Comment removed by: Benni Mack; Reason: half-finished
    When doing this, a logged-in non-admin can now preview ANY kind of fe-group restricted page by just adding ?ADMCMD_simUser=1 to a URL he/she guesses. My gut feeling is that ADMCMD_* should be re-set if the editor does not have access to the page, and then, behave as a regular visitor. I know we had this before, but I wonder why we don't have this in our tests (will check this as well)
  19. Benni Mack commented on patch set 6 03/25/25, 22:11

    Comment removed by: Benni Mack; Reason: removed
  20. Benni Mack commented on patch set 6 03/26/25, 11:08

    please see https://review.typo3.org/c/Packages/TYPO3.CMS/+/88762 as an alternative approach, can somebody please verify if the other change also works?
  21. Benni Mack abandoned the change 03/27/25, 11:32

  22. Benni Mack commented on patch set 6 03/27/25, 11:37

    aban
  23. Benni Mack commented on patch set 6 03/27/25, 11:37

    Reply

    Done