Review main Merged

80409[BUGFIX] Don't notify the editor about canceled SvgTree Ajax request

Rémy DANIEL CR +2 V +2 Easy +29 −2 updated 08/05/23, 20:16

Commit message

If the svg-tree component is embedded in an iframe,
and if the iframe src get changed by navigating to another url,
pending AjaxRequest will be cancelled by the browser,
without letting us the opportunity to properly catch the thrown error.

As a workaround, we register an unload event on the iframe's window,
and mute notifications to the user.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 812

  1. Rémy DANIEL uploaded patch set 1 08/05/23, 15:03

  2. Rémy DANIEL uploaded patch set 2 08/05/23, 15:09

  3. core-ci voted on patch set 1 V -1 08/05/23, 15:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45111

  4. core-ci voted on patch set 2 V -1 08/05/23, 15:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45112

  5. Rémy DANIEL uploaded patch set 3 V -1 08/05/23, 15:27

  6. core-ci voted on patch set 3 V +1 08/05/23, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45113

  7. Anja Leichsenring updated the commit message in patch set 4 V +1 08/05/23, 16:07

  8. core-ci voted on patch set 4 V +1 08/05/23, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45114

  9. Andreas Kienast voted on patch set 4 V +1 CR +1 08/05/23, 20:13

  10. Anja Leichsenring voted on patch set 4 V +1 CR +1 08/05/23, 20:13

  11. Andreas Kienast voted on patch set 4 V +2 CR +2 08/05/23, 20:16

  12. Andreas Kienast merged patch set 5 08/05/23, 20:16