Review 12.4 Merged

80416[BUGFIX] Only treat numerical route arguments as possible UIDs

Christian Kuhn CR +2 V +2 Easy +50 −0 updated 08/05/23, 21:08

Commit message

`PersistedAliasMapper` and `PersistentPatternMapper` both should only
use int-like string route arguments as possible UID candidates for the
following DB lookup.

Thus, check if the arguments are truly numerical before passing them to
the database queries.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Christian Kuhn uploaded patch set 1 08/05/23, 20:56

  2. core-ci voted on patch set 1 V +1 08/05/23, 21:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45130

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 08/05/23, 21:08

  4. Stefan Bürk merged patch set 2 08/05/23, 21:08