Review main Merged

80418[DOCS] Streamline the display of references to PHP class in EXT:form

Chris Müller CR +2 V +2 Normal +36 −32 updated 08/06/23, 12:22

Commit message

In some cases, classes are displayed like "TYPO3CMSCoreTypeContextualFeedbackSeverity"
as backslashes are neither quoted not enclosed in a ":php:" directive.

Where appropriate, we now link to the source code directly instead of just mentioning a class (with ":t3src:)". This is helpful, for example,
for the severity enum, when you just want to know the available cases.

Additionally, other mentions of PHP classes are now enclosed in a
":php:" directive instead double ticks.

Review

  • Code review CR +2 Done
    • Lina Wolf +2
  • Verified V +2 Done
    • Lina Wolf +2
    • core-ci +1 CI

Issues 1

Files 31

Show 11 more files

Review log 811

  1. Chris Müller uploaded patch set 1 08/06/23, 08:43

  2. core-ci voted on patch set 1 V +1 08/06/23, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45137

  3. Oliver Klee updated the commit message in patch set 2 V +1 08/06/23, 09:10

  4. Oliver Klee voted on patch set 2 V +1 CR +1 08/06/23, 09:12

  5. core-ci voted on patch set 2 V +1 08/06/23, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45140

  6. Lina Wolf updated the commit message in patch set 3 CR +1 V +1 08/06/23, 10:13

  7. Lina Wolf commented on patch set 3 08/06/23, 10:15

    Index.rst:661

    Please escape backslashes within the php directive as well
  8. core-ci voted on patch set 3 V +1 08/06/23, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45144

  9. Chris Müller commented on patch set 3 08/06/23, 11:11

    Index.rst:661 Reply

    Then the backslashes will be output doubled.
  10. Lina Wolf commented on patch set 3 V +2 CR +2 08/06/23, 12:22

    Index.rst:661 Reply

    Ack
  11. Lina Wolf merged patch set 4 08/06/23, 12:22