Review main Merged

80426[BUGFIX] Fix PHP 8 warnings in DataHandler

Thomas Hohn CR +2 V +2 Easy +2 −2 updated 08/07/23, 09:31

Commit message

Moved assignment of $destPid = $sortInfo['pid'] after check if
$sortInfo is an array, since the method call to getSortNumber
can return other values than an array.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Thomas Hohn uploaded patch set 1 08/07/23, 08:23

  2. core-ci voted on patch set 1 V +1 08/07/23, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45168

  3. Oliver Klee voted on patch set 1 V +1 CR +1 08/07/23, 08:43

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 08/07/23, 09:31

  5. Christian Kuhn merged patch set 2 08/07/23, 09:31