80433[!!!][FEATURE] Add UriBuilder->buildUriFromRequest
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 23
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php+2 −2
- typo3/sysext/backend/Classes/Controller/AbstractLinkBrowserController.php+3 −28
- typo3/sysext/backend/Classes/Controller/RecordListController.php+1 −1
- typo3/sysext/backend/Classes/ElementBrowser/AbstractElementBrowser.php+0 −18
- typo3/sysext/backend/Classes/ElementBrowser/DatabaseBrowser.php+1 −20
- typo3/sysext/backend/Classes/LinkHandler/PageLinkHandler.php+1 −22
- typo3/sysext/backend/Classes/LinkHandler/RecordLinkHandler.php+0 −19
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php+2 −2
- typo3/sysext/backend/Classes/Routing/UriBuilder.php12+15 −0
- typo3/sysext/backend/Classes/Tree/View/LinkParameterProviderInterface.php+3 −20
- typo3/sysext/backend/Classes/View/FolderUtilityRenderer.php+7 −10
- typo3/sysext/backend/Tests/Functional/Routing/UriBuilderTest.php+47 −2
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-101612-LinkParameterProviderInterfaceChanged.rstnew+49 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-101612-UriBuilder-buildUriFromRequest.rstnew+28 −0
- typo3/sysext/filelist/Classes/ElementBrowser/AbstractResourceBrowser.php+8 −28
- typo3/sysext/filelist/Classes/ElementBrowser/CreateFolderBrowser.php+1 −1
- typo3/sysext/filelist/Classes/ElementBrowser/FileBrowser.php+2 −2
- typo3/sysext/filelist/Classes/ElementBrowser/FolderBrowser.php+1 −1
- typo3/sysext/filelist/Classes/LinkHandler/AbstractResourceLinkHandler.php+6 −27
- typo3/sysext/filelist/Classes/LinkHandler/FileLinkHandler.php+2 −2
Review log 2128
Show 23 earlier messages
-
Benni Mack uploaded patch set 1 08/07/23, 13:16
-
core-ci voted on patch set 1 V -1 08/07/23, 13:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45191
-
Benni Mack uploaded patch set 2
V -108/07/23, 15:57
-
core-ci voted on patch set 2 V +1 08/07/23, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45195
-
Benni Mack uploaded patch set 3
V +108/07/23, 16:17 -
core-ci voted on patch set 3 V +1 08/07/23, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45196
-
Oliver Klee updated the commit message in patch set 4
V +108/07/23, 16:42 -
core-ci voted on patch set 4 V +1 08/07/23, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45197
-
Oliver Klee commented on patch set 4 08/07/23, 16:49
Looks generally very good! I've added some comments regarding smaller details. Do we need to mark this breaking and add a breaking RST as we're dropping a method from the non-internal interface?UriBuilder.php:134We don't need this PHPDoc annotations for the parameters that have native type declarations.UriBuilder.php:137Please let's directly have a native `string` type annotation for `$referenceType`.UriBuilder.php:139`$route` is an object. So the check should be `!…instanceof` or `=== null` here, not using it as a boolean. Also, please let's not add (new) Symfony-style `assigning things in a condition`, but have the assignment on a separate line to reduce the cognitive load for reading the code.UriBuilder.php:142Please let's have a guard clause (as guard clauses should handle the error case). -
Benni Mack uploaded patch set 5
V +108/07/23, 19:02 -
core-ci voted on patch set 5 V +1 08/07/23, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45200
-
Benni Mack commented on patch set 5 08/07/23, 22:15
UriBuilder.php:134ReplyDoneUriBuilder.php:137ReplyDoneUriBuilder.php:139ReplyDoneUriBuilder.php:142ReplyDone -
Benni Mack commented on patch set 5 08/07/23, 22:21
Reply
Removing methods from an interface is not per se breaking IMHO. I think we should add an Important.rst for this, and also remove isCurrentlySelectedItem() as well, as it serves no use anymore as well -
Benni Mack uploaded patch set 6
V +108/07/23, 22:26 -
core-ci voted on patch set 6 V +1 08/07/23, 22:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45205
-
Benni Mack uploaded patch set 7
V +108/07/23, 22:42 -
core-ci voted on patch set 7 V +1 08/07/23, 22:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45206
-
Benni Mack commented on patch set 7 08/07/23, 22:54
Reply
Done -
Anja Leichsenring voted on patch set 7 CR +1 08/08/23, 06:16
-
Oliver Klee voted on patch set 7 V +1 CR +1 08/08/23, 07:48
-
Oliver Klee commented on patch set 7 CR 0 08/08/23, 07:50
UriBuilder.php:132Please let's have tests for this new method. Should I have a go at the tests? -
Benni Mack commented on patch set 7 08/08/23, 07:54
UriBuilder.php:132ReplyWhat do you mean? I created functional tests -
Stefan Bürk voted on patch set 7 CR +1 08/08/23, 07:55
-
Oliver Klee commented on patch set 7 CR +1 08/08/23, 08:10
UriBuilder.php:132ReplyOh. I completely missed those. I must have had "tomatoes on my eyes". Sorry for this, and thanks for pointing this out! -
Stefan Bürk voted on patch set 7 V +1 08/08/23, 08:26
-
Stefan Bürk voted on patch set 7 V +2 CR +2 08/08/23, 08:29
-
Stefan Bürk merged patch set 8 08/08/23, 08:29
-
Benni Mack commented on patch set 8 08/08/23, 08:53
UriBuilder.php:132Replyno prob