Review main Merged

80454[BUGFIX] Compare new site properties with unprocessed current properties

Elias Häußler CR +2 V +2 Normal +64 −2 updated 01/20/25, 15:31

Commit message

Writing modified site configuration from the sites backend module
currently compares unprocessed new configuration with processed current
configuration. This causes problems when using placeholders in imported
YAML files.

With this change, the diff behavior when writing modified site config
is changed: New configuration properties are now compared against the
unprocessed current configuration properties. For current configuration,
YAML imports are still processed, whereas placeholder processing is
skipped.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 3042

Show 1217 earlier messages
  1. Elias Häußler uploaded patch set 1 08/08/23, 06:31

  2. Benni Mack commented on patch set 1 08/08/23, 06:40

    Hey, since we had quite some issues in this area, would you be willing to create a Functional Test for this?
  3. Elias Häußler commented on patch set 1 08/08/23, 06:42

    Reply

    Sure, will add some test cases.
  4. core-ci voted on patch set 1 V +1 08/08/23, 06:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45217

  5. Elias Häußler marked it work in progress 08/08/23, 06:43

  6. Elias Häußler uploaded patch set 2 V +1 08/08/23, 07:17

  7. Elias Häußler marked it ready for review 08/08/23, 07:18

  8. core-ci voted on patch set 2 V +1 08/08/23, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45219

  9. Elias Häußler uploaded patch set 3 V +1 07/10/24, 12:54

  10. Elias Häußler uploaded patch set 4 07/10/24, 12:55

  11. core-ci voted on patch set 3 V -1 07/10/24, 13:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61313

  12. core-ci voted on patch set 4 V +1 07/10/24, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61314

  13. Fabien Udriot voted on patch set 4 CR +1 07/10/24, 13:29

  14. Martin Adler voted on patch set 4 CR +1 07/29/24, 04:32

  15. Simon Schaufelberger uploaded patch set 5 CR +1 V +1 09/26/24, 10:11

  16. core-ci voted on patch set 5 V -1 09/26/24, 10:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66657

  17. Simon Schaufelberger uploaded patch set 6 V -1 09/26/24, 10:34

  1. core-ci voted on patch set 6 V +1 09/26/24, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66665

  2. Oliver Hader updated the commit message in patch set 7 V +1 10/18/24, 14:03

  3. Garvin Hicking updated the commit message in patch set 8 11/04/24, 15:19

  4. core-ci voted on patch set 8 V -1 11/04/24, 15:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69041

  5. Garvin Hicking rebased onto patch set 9 V -1 11/04/24, 15:44

  6. core-ci voted on patch set 9 V +1 11/04/24, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69042

  7. Garvin Hicking voted on patch set 9 CR +1 V +1 11/19/24, 10:39

  8. Benni Mack voted on patch set 9 CR +1 V +1 12/10/24, 14:15

  9. Garvin Hicking voted on patch set 9 CR +2 V +2 12/18/24, 16:59

  10. Garvin Hicking commented on patch set 9 12/18/24, 17:11

    (manual backport v12, verifying)
  11. Elias Häußler rebased onto patch set 10 CR +1 V +1 12/18/24, 18:24

  12. Elias Häußler uploaded patch set 11 12/18/24, 18:27

  13. Elias Häußler commented on patch set 11 12/18/24, 18:29

    Sorry for the hassle, I had to rebase because SiteWriterTest changed in the meantime and 13.4 backport was already failing because of that. Please vote again.
  14. core-ci voted on patch set 10 V -1 12/18/24, 18:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71404

  15. Elias Häußler rebased onto patch set 12 12/18/24, 18:31

  16. Elias Häußler rebased onto patch set 13 12/18/24, 18:33

  17. core-ci voted on patch set 11 V +1 12/18/24, 18:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71405

  18. core-ci voted on patch set 12 V +1 12/18/24, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71406

  19. Garvin Hicking voted on patch set 13 CR +1 V +1 12/18/24, 18:39

  20. core-ci voted on patch set 13 V +1 12/18/24, 18:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71407

  21. Garvin Hicking commented on patch set 13 12/19/24, 09:55

    Reply

    Done
  22. Simon Schaufelberger voted on patch set 13 CR +1 V +1 01/17/25, 15:39

  23. Oli Bartsch voted on patch set 13 CR +1 V +1 01/20/25, 10:30

  24. Garvin Hicking voted on patch set 13 CR +2 V +2 01/20/25, 15:31

  25. Garvin Hicking merged patch set 14 01/20/25, 15:31