80454[BUGFIX] Compare new site properties with unprocessed current properties
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Oli Bartsch +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Garvin Hicking +2
- Oli Bartsch +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Configuration/SiteWriter.php+4 −2
- typo3/sysext/core/Tests/Unit/Configuration/Fixtures/SiteConfigs/config3.yamlnew+13 −0
- typo3/sysext/core/Tests/Unit/Configuration/Fixtures/SiteConfigs/config3_expected.yamlnew+13 −0
- typo3/sysext/core/Tests/Unit/Configuration/Fixtures/SiteConfigs/include2.yamlnew+1 −0
- typo3/sysext/core/Tests/Unit/Configuration/SiteWriterTest.php+33 −0
Review log 3042
Show 1217 earlier messages
-
Elias Häußler uploaded patch set 1 08/08/23, 06:31
-
Benni Mack commented on patch set 1 08/08/23, 06:40
Hey, since we had quite some issues in this area, would you be willing to create a Functional Test for this? -
Elias Häußler commented on patch set 1 08/08/23, 06:42
Reply
Sure, will add some test cases. -
core-ci voted on patch set 1 V +1 08/08/23, 06:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45217
-
Elias Häußler marked it work in progress 08/08/23, 06:43
-
Elias Häußler uploaded patch set 2
V +108/08/23, 07:17 -
Elias Häußler marked it ready for review 08/08/23, 07:18
-
core-ci voted on patch set 2 V +1 08/08/23, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45219
-
Elias Häußler uploaded patch set 3
V +107/10/24, 12:54 -
Elias Häußler uploaded patch set 4 07/10/24, 12:55
-
core-ci voted on patch set 3 V -1 07/10/24, 13:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61313
-
core-ci voted on patch set 4 V +1 07/10/24, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61314
-
Fabien Udriot voted on patch set 4 CR +1 07/10/24, 13:29
-
Martin Adler voted on patch set 4 CR +1 07/29/24, 04:32
-
Simon Schaufelberger uploaded patch set 5
CR +1V +109/26/24, 10:11 -
core-ci voted on patch set 5 V -1 09/26/24, 10:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66657
-
Simon Schaufelberger uploaded patch set 6
V -109/26/24, 10:34
-
core-ci voted on patch set 6 V +1 09/26/24, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66665
-
Oliver Hader updated the commit message in patch set 7
V +110/18/24, 14:03 -
Garvin Hicking updated the commit message in patch set 8 11/04/24, 15:19
-
core-ci voted on patch set 8 V -1 11/04/24, 15:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69041
-
Garvin Hicking rebased onto patch set 9
V -111/04/24, 15:44 -
core-ci voted on patch set 9 V +1 11/04/24, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69042
-
Garvin Hicking voted on patch set 9 CR +1 V +1 11/19/24, 10:39
-
Benni Mack voted on patch set 9 CR +1 V +1 12/10/24, 14:15
-
Garvin Hicking voted on patch set 9 CR +2 V +2 12/18/24, 16:59
-
Garvin Hicking commented on patch set 9 12/18/24, 17:11
(manual backport v12, verifying) -
Elias Häußler rebased onto patch set 10
CR +1V +112/18/24, 18:24 -
Elias Häußler uploaded patch set 11 12/18/24, 18:27
-
Elias Häußler commented on patch set 11 12/18/24, 18:29
Sorry for the hassle, I had to rebase because SiteWriterTest changed in the meantime and 13.4 backport was already failing because of that. Please vote again. -
core-ci voted on patch set 10 V -1 12/18/24, 18:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71404
-
Elias Häußler rebased onto patch set 12 12/18/24, 18:31
-
Elias Häußler rebased onto patch set 13 12/18/24, 18:33
-
core-ci voted on patch set 11 V +1 12/18/24, 18:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71405
-
core-ci voted on patch set 12 V +1 12/18/24, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71406
-
Garvin Hicking voted on patch set 13 CR +1 V +1 12/18/24, 18:39
-
core-ci voted on patch set 13 V +1 12/18/24, 18:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71407
-
Garvin Hicking commented on patch set 13 12/19/24, 09:55
Reply
Done -
Simon Schaufelberger voted on patch set 13 CR +1 V +1 01/17/25, 15:39
-
Oli Bartsch voted on patch set 13 CR +1 V +1 01/20/25, 10:30
-
Garvin Hicking voted on patch set 13 CR +2 V +2 01/20/25, 15:31
-
Garvin Hicking merged patch set 14 01/20/25, 15:31