Review main Merged

80462[TASK] Migrate from jQuery in `@typo3/scheduler/scheduler`

Andreas Kienast CR +2 V +2 Normal +75 −73 updated 08/10/23, 13:33

Commit message

This patch removes jQuery from the `@typo3/scheduler/scheduler` module
in favor of native APIs.

Extra fields are now hidden via the `hidden` attribute and not via CSS
styling anymore.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1215

  1. Andreas Kienast uploaded patch set 1 08/08/23, 15:07

  2. Andreas Kienast uploaded patch set 2 08/08/23, 15:13

  3. core-ci voted on patch set 1 V +1 08/08/23, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45243

  4. core-ci voted on patch set 2 V +1 08/08/23, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45244

  5. Andreas Nedbal voted on patch set 2 V +1 CR +1 08/09/23, 08:20

  6. Benni Mack commented on patch set 2 08/10/23, 12:41

    I think we could / should backport this. Seems OK to do so and adds a bit of perf improvements?
  7. Andreas Kienast commented on patch set 2 08/10/23, 12:45

    Reply

    Albeit the performance gain is probably homeopathic, backporting to 12.4 is ok, I guess.
  8. Andreas Kienast updated the commit message in patch set 3 CR +1 V +1 08/10/23, 12:45

  9. core-ci voted on patch set 3 V +1 08/10/23, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45334

  10. Christian Kuhn voted on patch set 3 V +1 CR +1 08/10/23, 13:15

  11. Stefan Bürk voted on patch set 3 CR +1 08/10/23, 13:23

  12. Andreas Nedbal voted on patch set 3 V +1 CR +1 08/10/23, 13:25

  13. Stefan Bürk voted on patch set 3 V +1 08/10/23, 13:28

  14. Andreas Kienast voted on patch set 3 V +2 CR +2 08/10/23, 13:33

  15. Andreas Kienast merged patch set 4 08/10/23, 13:33