Review main Abandoned

80492[WIP][TASK] Replace `php -S` with apache2 and libapache-php

Stefan Bürk CR 0 V 0 Normal +103 −60 updated 08/22/23, 05:45

Commit message

This change uses a apache2 based image using the
libapache-php module as replacement for the php
webserver `php -S`. That allows us to configure
a proper DocumentRoot now instead of using paths
from the document root. Therefore, files outside
the acceptance test instance are not retrievable
which can be seen as a additional guard.

* Use port 80 instead of 8000 the for acceptance
  and acceptanceInstall tests webserver.
* Use the acceptance test as DocumentRoot instead
  of the monorepo root.
* Copy several `.htaccess` files to the acceptance
  test instance as we now have a real apache2.
* Copy the favicon.ico to the test instance instead
  of the monorepo root.
* Ensure that created frontend siteconfiguration no
  longer uses the path into the test instance from
  the repository root. Simply use `/`.
* Instead of creating a additional container instance
  to execute the tests with codeception use `exec` in
  the spawned apache2 webserver container. Reduces the
  count of started containers and eliminates the need
  to mount for example the sqlite to two container.

Extract as pre-patch:

* [BUGFIX] Handle `UniqueConstraintViolationException`
  in `Registry->set()` properly.
* [BUGFIX] Stabilize EnableFileServiceTest
* [BUGFIX] Stabilize UsersCest
* [BUGFIX] Stabilize PageModuleCest

Note: Currently a dedicated build image is used as a
      test. This needs to be moved to the core-testing
      images instead, if this can be elevated and used
      as working replacement solution.

Used command(s):

> composer require --dev \
    "typo3/testing-framework":"dev-stefan-1"

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Files 12