Review main Merged

80494[TASK] Fix PHP 8 compatibility in DataHandler

Ernesto Baschny CR +2 V +2 Easy +1 −1 updated 08/09/23, 21:17

Commit message

In case you add a new TCA field of type "slug" in the pages table
but without a config "eval", you get an exception in the backend.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 810

  1. Ernesto Baschny uploaded patch set 1 08/09/23, 17:15

  2. core-ci voted on patch set 1 V +1 08/09/23, 17:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45285

  3. Ernesto Baschny commented on patch set 1 08/09/23, 17:23

    DataHandler.php:8779

    same fix as in the function right above this one. This one was missed two years ago. @lolli 😊
  4. Oliver Klee commented on patch set 1 V +1 CR +1 08/09/23, 18:55

    DataHandler.php:8779 Reply

    Ack
  5. Oliver Klee updated the commit message in patch set 2 CR +1 V +1 08/09/23, 18:55

  6. Oliver Klee voted on patch set 2 V +1 CR +1 08/09/23, 18:56

  7. core-ci voted on patch set 2 V +1 08/09/23, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45286

  8. Benni Mack voted on patch set 2 V +1 CR +1 08/09/23, 21:05

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 08/09/23, 21:17

  10. Christian Kuhn merged patch set 3 08/09/23, 21:17