Review main Merged

80499[TASK] De-mess EM InstallUtility a bit

Christian Kuhn CR +2 V +2 Hard +87 −382 updated 08/10/23, 07:46

Commit message

Service classes in Extensionmanager\Utility
are a great example on "when class abstraction
goes wrong" - we're fighting with those for
lots of major versions already.

To tame this mess, this first patch applies a rather
straight streamlining to InstallUtility: Use constructor
property promotion, move public methods up in the class,
remove heavy-mocking and useless unit tests that
only check if certain sub-methods are called.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2