Review main Merged

80501[TASK] Replace jquery.minicolors with alwan

Andreas Kienast CR +2 V +2 Hard +417 −355 updated 08/10/23, 10:31

Commit message

The current color picker plugin based on jQuery is now replaced with
alwan [1]. alwan is a dependency-free color picker solution that also
allows us to integrate color swatches in the future.

[1]: https://sofianchouaib.github.io/alwan/

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Andreas Nedbal +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Andreas Nedbal +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 1420

  1. Andreas Kienast uploaded patch set 1 08/10/23, 07:42

  2. Andreas Kienast commented on patch set 1 CR -1 08/10/23, 07:45

    Gruntfile is incomplete
  3. Andreas Kienast uploaded patch set 2 CR -1 08/10/23, 07:49

  4. Andreas Kienast uploaded patch set 3 08/10/23, 07:54

  5. core-ci voted on patch set 2 V -1 08/10/23, 07:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45311

  6. core-ci voted on patch set 1 V -1 08/10/23, 07:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45310

  7. Andreas Kienast uploaded patch set 4 08/10/23, 07:58

  8. core-ci voted on patch set 3 V -1 08/10/23, 07:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45312

  9. core-ci voted on patch set 4 V +1 08/10/23, 08:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45313

  10. Andreas Nedbal commented on patch set 4 08/10/23, 08:49

    ExternalLibraries.html:122

    minor nitpicks: - Should probably be "Alwan Color Picker" as that's how the page cases it itself - Link includes a double-slash at the end (not invalid, but not pretty either)
  11. Andreas Kienast commented on patch set 4 08/10/23, 09:15

    ExternalLibraries.html:122 Reply

    Ack
  12. Andreas Kienast uploaded patch set 5 V +1 08/10/23, 09:16

  13. Benjamin Franzke commented on patch set 5 CR -1 08/10/23, 09:21

    on it
  14. core-ci voted on patch set 5 V +1 08/10/23, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45319

  15. Benjamin Franzke uploaded patch set 6 CR -1 V +1 08/10/23, 10:04

  16. Benjamin Franzke commented on patch set 6 08/10/23, 10:04

    I don't really like that we have to copy the css into our sources, in order to properly support dark/light mode colorschemes, but for the lack of current alternatives that is fine by me. (Would love an alternative that used shadow dom in here)
  17. core-ci voted on patch set 6 V +1 08/10/23, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45321

  18. Andreas Nedbal voted on patch set 6 V +1 CR +1 08/10/23, 10:17

  19. Andreas Kienast voted on patch set 6 V +2 CR +2 08/10/23, 10:31

  20. Andreas Kienast merged patch set 7 08/10/23, 10:31