80501[TASK] Replace jquery.minicolors with alwan
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Andreas Nedbal +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Andreas Nedbal +1
- core-ci +1 CI
Issues 1
Files 14
- Build/Sources/Sass/component/_colorpicker.scss+331 −249
- Build/Sources/TypeScript/backend/color-picker.ts+17 −20
- Build/types/JQuery/minicolors.d.tsdeleted+0 −4
- Build/Gruntfile.js+1 −6
- Build/package-lock.json+6 −10
- Build/package.json+1 −1
- typo3/sysext/backend/Configuration/JavaScriptModules.php+1 −0
- typo3/sysext/backend/Resources/Private/Partials/About/ExternalLibraries.html2+2 −2
- typo3/sysext/backend/Resources/Public/Css/backend.css+51 −36
- typo3/sysext/backend/Resources/Public/Images/colorpicker/jquery.minicolors.pngdeletedbinary
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/alwan.jsnew+6 −0
- typo3/sysext/backend/Resources/Public/JavaScript/color-picker.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/jquery/minicolors.jsdeleted+0 −20
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/jquery/README.txtdeleted+0 −6
Review log 1420
-
Andreas Kienast uploaded patch set 1 08/10/23, 07:42
-
Andreas Kienast commented on patch set 1 CR -1 08/10/23, 07:45
Gruntfile is incomplete -
Andreas Kienast uploaded patch set 2
CR -108/10/23, 07:49 -
Andreas Kienast uploaded patch set 3 08/10/23, 07:54
-
core-ci voted on patch set 2 V -1 08/10/23, 07:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45311
-
core-ci voted on patch set 1 V -1 08/10/23, 07:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45310
-
Andreas Kienast uploaded patch set 4 08/10/23, 07:58
-
core-ci voted on patch set 3 V -1 08/10/23, 07:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45312
-
core-ci voted on patch set 4 V +1 08/10/23, 08:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45313
-
Andreas Nedbal commented on patch set 4 08/10/23, 08:49
ExternalLibraries.html:122minor nitpicks: - Should probably be "Alwan Color Picker" as that's how the page cases it itself - Link includes a double-slash at the end (not invalid, but not pretty either) -
Andreas Kienast commented on patch set 4 08/10/23, 09:15
ExternalLibraries.html:122ReplyAck -
Andreas Kienast uploaded patch set 5
V +108/10/23, 09:16 -
Benjamin Franzke commented on patch set 5 CR -1 08/10/23, 09:21
on it -
core-ci voted on patch set 5 V +1 08/10/23, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45319
-
Benjamin Franzke uploaded patch set 6
CR -1V +108/10/23, 10:04 -
Benjamin Franzke commented on patch set 6 08/10/23, 10:04
I don't really like that we have to copy the css into our sources, in order to properly support dark/light mode colorschemes, but for the lack of current alternatives that is fine by me. (Would love an alternative that used shadow dom in here) -
core-ci voted on patch set 6 V +1 08/10/23, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45321
-
Andreas Nedbal voted on patch set 6 V +1 CR +1 08/10/23, 10:17
-
Andreas Kienast voted on patch set 6 V +2 CR +2 08/10/23, 10:31
-
Andreas Kienast merged patch set 7 08/10/23, 10:31