Review 12.4 Merged

80508[BUGFIX] Keep "Add media by URL" modal open on error

Andreas Kienast CR +2 V +2 Easy +7 −23 updated 08/10/23, 19:07

Commit message

If the "Add media by URL" button is used in FormEngine, a modal appears
with an input field, allowing the user to enter a media URL.
If an error occurs, the modal now stays open and the error is rendered
via a notification. Previously, the modal was closed and another modal
was opened informing about the error.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Anja Leichsenring +1
    • Lina Wolf +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Anja Leichsenring +1
    • Lina Wolf +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Andreas Kienast uploaded patch set 1 08/10/23, 13:40

  2. Andreas Kienast commented on patch set 1 08/10/23, 13:41

    This is relevant for 12.4 only. Here's the related main patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80507
  3. core-ci voted on patch set 1 V +1 08/10/23, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45339

  4. Anja Leichsenring voted on patch set 1 V +1 CR +1 08/10/23, 18:49

  5. Lina Wolf commented on patch set 1 V +1 CR +1 08/10/23, 19:00

    Code looks good as far as I can tell and it works in my installation. Thanks for the change!
  6. Andreas Nedbal voted on patch set 1 V +2 CR +2 08/10/23, 19:06

  7. Andreas Nedbal merged patch set 2 08/10/23, 19:07