Review main Merged

80511[BUGFIX] Add accessibility labels to quick edit buttons

Albrecht Köhnlein CR +2 V +2 Hard +408 −140 updated 09/13/23, 14:12

Commit message

The quick edit features for the page title in the page module and the
quick edit feature for scheduler groups do both have buttons with icons
only. To increase accessibility and improve the usability with screen
readers in the TYPO3 backend, labels are added.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 1722

  1. Albrecht Köhnlein uploaded patch set 1 08/10/23, 16:02

  2. core-ci voted on patch set 1 V -1 08/10/23, 16:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45346

  3. Albrecht Köhnlein uploaded patch set 2 V -1 08/10/23, 17:27

  4. core-ci voted on patch set 2 V +1 08/10/23, 17:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45349

  5. Stefan Bürk rebased onto patch set 3 V +1 09/05/23, 15:04

  6. core-ci voted on patch set 3 V +1 09/05/23, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46243

  7. André Buchmann commented on patch set 3 09/05/23, 15:21

    locallang.xlf:575

    Is this label clear enough for the editor that he is in the scheduler module context? Or should it be "Edit the scheduler group name"? Like we have it for pages with "Edit the page title".
  8. Albrecht Köhnlein commented on patch set 3 09/05/23, 15:31

    locallang.xlf:575 Reply

    In my very personal opinion, the headline "scheduled task" which is placed above the list of tasks and groups should be enough to help him remember, he is in the scheduler module.
  9. André Buchmann commented on patch set 3 V +1 CR +1 09/05/23, 15:41

    locallang.xlf:575 Reply

    I'm fine with that
  10. Benjamin Franzke commented on patch set 3 09/06/23, 09:10

    Any chance to use the existing "Save" label (id="save") from typo3/sysext/core/Resources/Private/Language/locallang_common.xlf (?)
  11. Albrecht Köhnlein commented on patch set 3 09/06/23, 12:57

    Reply

    I would prefer not to use too generic labels. As a sighted user, you can know the context of the button from visual elements like position, etc. A blind user needs more context, I think. The <form> itself, where the button is located, also has no accessible label. So I would like to add some indication of what the "save" button is supposed to save.
  12. Benjamin Kott uploaded patch set 4 CR +1 V +1 09/13/23, 11:25

  13. Benjamin Kott commented on patch set 4 09/13/23, 11:27

    Reply

    We are using the default labels for save and cancel for now. Additional labels were added to the input fields and code was prepared to have the labels exchanged at a later point.
  14. Benjamin Kott commented on patch set 4 09/13/23, 11:27

    Reply

    Done
  15. Benjamin Franzke voted on patch set 4 V +1 CR +1 09/13/23, 11:33

  16. Benjamin Kott commented on patch set 4 CR -1 09/13/23, 11:37

    on it
  17. core-ci voted on patch set 4 V -1 09/13/23, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46541

  18. Benjamin Kott uploaded patch set 5 CR +1 V +1 09/13/23, 13:44

  19. core-ci voted on patch set 5 V +1 09/13/23, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46549

  20. Benjamin Franzke voted on patch set 5 V +1 CR +1 09/13/23, 14:02

  21. Benjamin Kott voted on patch set 5 V +2 CR +2 09/13/23, 14:03

  22. Benjamin Kott merged patch set 6 09/13/23, 14:12