80511[BUGFIX] Add accessibility labels to quick edit buttons
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- core-ci +1 CI
Issues 1
Files 15
- Build/Sources/Sass/component/_panel.scss+23 −0
- Build/Sources/TypeScript/backend/element/editable-page-title.ts+58 −11
- Build/Sources/TypeScript/scheduler/scheduler-editable-group-name.ts+86 −25
- typo3/sysext/backend/Resources/Private/Language/locallang_layout.xlf+3 −0
- typo3/sysext/backend/Resources/Private/Templates/PageLayout/PageModule.html+6 −0
- typo3/sysext/backend/Resources/Private/Templates/RecordList.html+6 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+3 −0
- typo3/sysext/backend/Resources/Public/JavaScript/element/editable-page-title.js+52 −11
- typo3/sysext/core/Tests/Acceptance/Application/Scheduler/TaskGroupsCest.php+1 −1
- typo3/sysext/scheduler/Resources/Private/Language/locallang.xlf3+6 −0
- typo3/sysext/scheduler/Resources/Private/Partials/GroupUnusedList.html+6 −6
- typo3/sysext/scheduler/Resources/Private/Partials/MultiRecordSelectionActions.html+3 −5
- typo3/sysext/scheduler/Resources/Private/Partials/TaskList.html+67 −61
- typo3/sysext/scheduler/Resources/Private/Templates/ListTasks.html+5 −1
- typo3/sysext/scheduler/Resources/Public/JavaScript/scheduler-editable-group-name.js+83 −19
Review log 1722
-
Albrecht Köhnlein uploaded patch set 1 08/10/23, 16:02
-
core-ci voted on patch set 1 V -1 08/10/23, 16:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45346
-
Albrecht Köhnlein uploaded patch set 2
V -108/10/23, 17:27 -
core-ci voted on patch set 2 V +1 08/10/23, 17:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45349
-
Stefan Bürk rebased onto patch set 3
V +109/05/23, 15:04 -
core-ci voted on patch set 3 V +1 09/05/23, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46243
-
André Buchmann commented on patch set 3 09/05/23, 15:21
-
Albrecht Köhnlein commented on patch set 3 09/05/23, 15:31
locallang.xlf:575ReplyIn my very personal opinion, the headline "scheduled task" which is placed above the list of tasks and groups should be enough to help him remember, he is in the scheduler module. -
André Buchmann commented on patch set 3 V +1 CR +1 09/05/23, 15:41
locallang.xlf:575ReplyI'm fine with that -
Benjamin Franzke commented on patch set 3 09/06/23, 09:10
Any chance to use the existing "Save" label (id="save") from typo3/sysext/core/Resources/Private/Language/locallang_common.xlf (?) -
Albrecht Köhnlein commented on patch set 3 09/06/23, 12:57
Reply
I would prefer not to use too generic labels. As a sighted user, you can know the context of the button from visual elements like position, etc. A blind user needs more context, I think. The <form> itself, where the button is located, also has no accessible label. So I would like to add some indication of what the "save" button is supposed to save. -
Benjamin Kott uploaded patch set 4
CR +1V +109/13/23, 11:25 -
Benjamin Kott commented on patch set 4 09/13/23, 11:27
Reply
We are using the default labels for save and cancel for now. Additional labels were added to the input fields and code was prepared to have the labels exchanged at a later point. -
Benjamin Kott commented on patch set 4 09/13/23, 11:27
Reply
Done -
Benjamin Franzke voted on patch set 4 V +1 CR +1 09/13/23, 11:33
-
Benjamin Kott commented on patch set 4 CR -1 09/13/23, 11:37
on it -
core-ci voted on patch set 4 V -1 09/13/23, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46541
-
Benjamin Kott uploaded patch set 5
CR +1V +109/13/23, 13:44 -
core-ci voted on patch set 5 V +1 09/13/23, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46549
-
Benjamin Franzke voted on patch set 5 V +1 CR +1 09/13/23, 14:02
-
Benjamin Kott voted on patch set 5 V +2 CR +2 09/13/23, 14:03
-
Benjamin Kott merged patch set 6 09/13/23, 14:12
locallang.xlf:575