Review main Merged

80512[BUGFIX] Fix undefined array key MPvar in PageSlugCandidateProvider

Thomas Hohn CR +2 V +2 Easy +1 −1 updated 01/31/25, 13:13

Commit message

Fix undefined array key MPvar in PageSlugCandidateProvider by adding
a null coalescing operator.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 3338

Show 1013 earlier messages
  1. Thomas Hohn uploaded patch set 1 08/10/23, 17:00

  2. core-ci voted on patch set 1 V +1 08/10/23, 17:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45348

  3. Oliver Klee commented on patch set 1 08/10/23, 18:11

    Have you checked if 11.5 is affected as well?
  4. Oliver Klee updated the commit message in patch set 2 V +1 08/10/23, 18:46

  5. Oliver Klee commented on patch set 2 08/10/23, 18:47

    Reply

    Done - the code is the same in 11.5.
  6. core-ci voted on patch set 2 V +1 08/10/23, 18:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45352

  7. Thomas Hohn updated the commit message in patch set 3 V +1 08/13/23, 18:34

  8. core-ci voted on patch set 3 V +1 08/13/23, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45457

  9. Philipp Parzer voted on patch set 3 V +1 08/13/23, 20:30

  10. Markus Klein commented on patch set 3 09/22/23, 08:47

    PageSlugCandidateProvider.php:391

    are we sure $mountPointPage['MPvar'] is always set?
  11. Simon Schaufelberger commented on patch set 3 09/22/23, 09:08

    I have tried to reproduce the bug but for me everything works and $pageCandidate['MPvar'] has a value. Can somebody verify this bug please?
  12. Oliver Klee commented on patch set 3 10/08/23, 13:23

    How should we proceed here?
  13. Simon Schaufelberger commented on patch set 3 10/09/23, 18:31

    Reply

    you can try to reproduce the bug and see if this fix is actually needed.
  1. Philipp Parzer voted on patch set 3 CR +1 10/10/23, 05:54

  2. Thomas Hohn commented on patch set 3 10/10/23, 06:06

    Reply

    Apparently Phillip Parzer has verified that it fixes the issue
  3. Thomas Hohn commented on patch set 3 10/10/23, 06:56

    Reply

    Apparently Phillip Parzer has verified that it fixes the issue

    PageSlugCandidateProvider.php:391 Reply

    As far as I could read the code where it's loaded
  4. Oliver Klee voted on patch set 3 V +1 CR +1 10/10/23, 07:45

  5. Markus Klein voted on patch set 3 CR +1 10/12/23, 12:53

  6. Benni Mack commented on patch set 3 12/05/23, 17:15

    Still I'd like to know how to reproduce so we can actually fix the underlying cause somwheere in PageRepository
  7. Simon Schaufelberger commented on patch set 3 05/14/24, 11:50

    Reply

    Can you please provide an sql dump or something how I can verify this?
  8. Georg Ringer commented on patch set 3 CR +1 V +1 05/28/24, 21:25

    PageSlugCandidateProvider.php:391 Reply

    I can reproduce it by changing the mount_pid_ol of one of the following pages to 1, see forge issue
  9. Stefan Bürk voted on patch set 3 CR -1 V -1 05/29/24, 09:00

  10. Thomas Hohn commented on patch set 3 08/21/24, 11:02

    Reply

    Please ask @p.parzer@siwa.at - I only provided the proposed. There now seems to be a way to reproduce it
  11. Thomas Hohn commented on patch set 3 08/22/24, 04:36

    Reply

    @simonschaufi+typo3@gmail.com - there seems to be a description in the issue on how to reproduce it
  12. Thomas Hohn uploaded patch set 4 CR +1 V +1 08/22/24, 04:38

  13. core-ci voted on patch set 4 V +1 08/22/24, 04:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63950

  14. Markus Klein voted on patch set 4 CR +1 08/22/24, 08:21

  15. Simon Schaufelberger commented on patch set 4 08/22/24, 14:23

    Reply

    yes but I still can't reproduce it.
  16. Thomas Hohn commented on patch set 4 08/23/24, 06:14

    Reply

    Hi @georg.ringer@gmail.com - didn't you manage to reproduce it?
  17. Oliver Klee wrote 08/23/24, 08:15

    Removed reviewer Oliver Klee.
  18. Philipp Parzer voted on patch set 4 CR +1 09/18/24, 05:52

  19. Benni Mack updated the commit message in patch set 5 CR +1 V +1 10/18/24, 13:53

  20. Benni Mack rebased onto patch set 6 01/31/25, 12:02

  21. core-ci voted on patch set 6 V +1 01/31/25, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73263

  22. Benni Mack voted on patch set 6 CR +1 V +1 01/31/25, 12:53

  23. Christian Kuhn commented on patch set 6 01/31/25, 13:05

    Reply

    georg answered in the issue he's able to reproduce.
  24. Christian Kuhn voted on patch set 6 CR +2 V +2 01/31/25, 13:05

  25. Christian Kuhn merged patch set 7 01/31/25, 13:13