80514[FEATURE] Add option to render media added by URL with data-src
Commit message
Review
-
Code review CR 0
-
Verified V -1
- core-ci -1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/Resource/Rendering/VimeoRenderer.php3+2 −2
- typo3/sysext/core/Classes/Resource/Rendering/YouTubeRenderer.php2+2 −2
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-96477-AddOptionToRenderMediaAddedByURLWithData-src.rstnew+26 −0
- typo3/sysext/fluid/Classes/ViewHelpers/MediaViewHelper.php3+2 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/Helper/ContentElement.typoscript+2 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/constants.typoscript+3 −0
- typo3/sysext/fluid_styled_content/Resources/Private/Partials/Media/Rendering/Video.html+1 −1
Review log 1218
-
Max Frerichs uploaded patch set 1 08/10/23, 19:19
-
core-ci voted on patch set 1 V -1 08/10/23, 19:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45355
-
Max Frerichs uploaded patch set 2
V -108/10/23, 19:56 -
core-ci voted on patch set 2 V -1 08/10/23, 20:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45358
-
Chris Müller commented on patch set 2 CR -1 08/11/23, 07:07
Thanks for your contribution. I added some remarks. Please don't forget to add a feature rst as described here: https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/AddingDocumentation/Index.htmlVimeoRenderer.php:94Here you check for a "true" string, but should be a bool?YouTubeRenderer.php:94Here you check for a "true" string, but should be a bool?MediaViewHelper.php:91You register the attribute as string, but it has a default value of false (bool). AI am not sure if "data-src" is the correct name for the attribute. From that name it is not really clear what values it can hold. Also, the other attributes are lowerCamelCase, not dashed. Maybe "useDataSrc"? -
Benni Mack commented on patch set 2 08/11/23, 20:47
Hey Max, do you know https://extensions.typo3.org/extension/twoclickmedia ? Maybe we could have a solution like this out-of-the-box in TYPO3 Core with a toggle in e.g. the constant editor to enable this? -
Max Frerichs commented on patch set 2 08/11/23, 21:11
VimeoRenderer.php:94ReplyYes, this is not correct. I'll fix it and change it to bool.YouTubeRenderer.php:94Reply UnresolvedAcknowledged (see comment above)MediaViewHelper.php:91ReplyIn fact, I had first named the attribute useDataSrc before I renamed it to "data-src" and pushed the patchset. But you are right, "useDataSrc" makes more sense. To the type of the default value: Yeah, you're right. I'll fix it. (adding feature rst as well) Thanks for the remarks! -
Max Frerichs uploaded patch set 3
CR -1V -108/11/23, 23:37 -
Max Frerichs commented on patch set 3 08/11/23, 23:43
Reply
Hi Benni, thanks for your input, sounds good to me. I've uploaded a new patchset that implements the option to configure this via TypoScript constant. This extension ships with some default JS, CSS and other assets to provide an overlay. Should this be integrated into the TYPO3 core as well? -
core-ci voted on patch set 3 V -1 08/11/23, 23:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45398
-
Max Frerichs uploaded patch set 4
V -108/11/23, 23:44 -
core-ci voted on patch set 4 V -1 08/11/23, 23:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45399
-
Max Frerichs uploaded patch set 5
V -108/12/23, 00:01 -
core-ci voted on patch set 5 V -1 08/12/23, 00:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45400
-
Max Frerichs rebased onto patch set 6
V -108/13/23, 10:07 -
core-ci voted on patch set 6 V -1 08/13/23, 10:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45444
-
Max Frerichs commented on patch set 6 08/13/23, 11:58
VimeoRenderer.php:94ReplyDoneMediaViewHelper.php:91ReplyDone -
Garvin Hicking abandoned the change 02/19/26, 21:25
Should be solved via #108648 (https://review.typo3.org/c/Packages/TYPO3.CMS/+/92345)