Review main Merged

80520[TASK] Require doctrine/lexer:^3.0

Christian Kuhn CR +2 V +2 Easy +3 −3 updated 08/11/23, 10:31

Commit message

The lexer is used in the core ext_tables.sql
parser. Other dependencies that use it allow
3.0 already, it comes with more PHP type hints,
it should be fair to require ^3.0 with core v13.

> composer req doctrine/lexer:^3.0
> composer req doctrine/lexer:^3.0 -d typo3/sysext/core --no-update

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1013

  1. Christian Kuhn uploaded patch set 1 08/11/23, 09:37

  2. Oliver Klee voted on patch set 1 CR +1 08/11/23, 09:38

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 08/11/23, 09:40

  4. core-ci voted on patch set 1 V -1 08/11/23, 09:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45373

  5. Christian Kuhn uploaded patch set 2 CR +1 V +1 08/11/23, 09:47

  6. Christian Kuhn updated the commit message in patch set 3 08/11/23, 09:49

  7. Oliver Klee voted on patch set 3 CR +1 08/11/23, 09:51

  8. core-ci voted on patch set 2 V +1 08/11/23, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45374

  9. core-ci voted on patch set 3 V +1 08/11/23, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45375

  10. Oliver Klee voted on patch set 3 V +1 08/11/23, 10:00

  11. Andreas Kienast voted on patch set 3 V +1 CR +1 08/11/23, 10:29

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 08/11/23, 10:31

  13. Christian Kuhn merged patch set 4 08/11/23, 10:31