Review main Merged

80521[TASK] Do not use to-be deprecated `unload` event

Andreas Kienast CR +2 V +2 Easy +12 −14 updated 08/16/23, 08:10

Commit message

Google Chrome (and other browser vendors will probably follow)
deprecates the unload event with Chrome 117 [1] and encourages using
the Page Lifecycle API [2] instead. This patch replaces any usage of
the `unload` event with the `pagehide` event that is available for all
supported browsers [3].

[1] https://developer.chrome.com/en/blog/deprecating-unload/
[2] https://developer.chrome.com/blog/page-lifecycle-api/
[3] https://caniuse.com/mdn-api_window_pagehide_event

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1013

  1. Andreas Kienast uploaded patch set 1 08/11/23, 12:40

  2. Andreas Kienast updated the commit message in patch set 2 08/11/23, 12:40

  3. Andreas Kienast uploaded patch set 3 08/11/23, 12:41

  4. core-ci voted on patch set 3 V +1 08/11/23, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45383

  5. Andreas Kienast uploaded patch set 4 V +1 08/11/23, 13:50

  6. core-ci voted on patch set 4 V +1 08/11/23, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45389

  7. Stefan Bürk voted on patch set 4 V +1 CR +1 08/15/23, 14:23

  8. Benjamin Franzke commented on patch set 4 CR -1 08/16/23, 06:49

    Look good. but: on it (want to check routing details)
  9. Benjamin Franzke uploaded patch set 5 CR +1 V +1 08/16/23, 07:34

  10. core-ci voted on patch set 5 V +1 08/16/23, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45530

  11. Stefan Bürk voted on patch set 5 V +1 CR +1 08/16/23, 07:43

  12. Benjamin Franzke voted on patch set 5 V +2 CR +2 08/16/23, 07:49

  13. Benjamin Franzke merged patch set 6 08/16/23, 08:10