Review main Merged

80524[TASK] Always reset singleton instances for whole testcases

Oliver Klee CR +2 V +2 Easy +11 −16 updated 08/11/23, 19:58

Commit message

For (unit) tests that use singletons, the singletone instances should
always be reset for all tests from the corresponding testcase, not
only for individual tests.

This reduces the risk of new tests missing the singleton reset.
Also, it makes the code a bit shorter.

Also drop one instance of setting `$this->resetSingletonInstances`
where the property already was set to `true`.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 7