Review main Merged

80527[TASK] Propagate cache tags of cached page parts to page cache tags

Sascha Nowak CR +2 V +2 Normal +53 −13 updated 11/20/23, 21:28

Commit message

When using the first-class TypoScript cache or stdWrap cache functions
the given cache tags of the content object are not correctly propagated
to pages on consecutive requests. The cache tags were not stored in the
cache entry, which is why they were never applied to the rendered page
cache once they were reused.

This patch adds support to store and restore the cache tag like #90775
did. Thus cache tags of subparts are now added as page cache tags.

[1] https://docs.typo3.org/m/typo3/reference-typoscript/main/en-us/Functions/Cache.html#cache-as-first-class-function

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1623

  1. Sascha Nowak uploaded patch set 1 08/11/23, 15:40

  2. core-ci voted on patch set 1 V -1 08/11/23, 15:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45394

  3. Sascha Nowak uploaded patch set 2 V -1 08/11/23, 16:14

  4. Sascha Nowak uploaded patch set 3 08/11/23, 16:20

  5. core-ci voted on patch set 2 V -1 08/11/23, 16:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45395

  6. core-ci voted on patch set 3 V +1 08/11/23, 16:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45396

  7. Benni Mack voted on patch set 3 CR +1 08/11/23, 19:48

  8. Jörg Bösche voted on patch set 3 CR +1 08/14/23, 19:11

  9. Benjamin Franzke uploaded patch set 4 CR +1 V +1 11/20/23, 13:38

  10. core-ci voted on patch set 4 V +1 11/20/23, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49132

  11. Benjamin Franzke commented on patch set 4 CR -1 11/20/23, 13:58

    on it
  12. Benjamin Franzke uploaded patch set 5 CR -1 V +1 11/20/23, 16:05

  13. Benjamin Franzke voted on patch set 5 V +1 CR +1 11/20/23, 16:06

  14. core-ci voted on patch set 5 V +1 11/20/23, 16:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49152

  15. Benjamin Franzke uploaded patch set 6 CR +1 V +1 11/20/23, 16:15

  16. core-ci voted on patch set 6 V +1 11/20/23, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49154

  17. Benjamin Franzke commented on patch set 6 V +1 CR +1 11/20/23, 16:22

    ContentObjectRenderer.php:5508

    Note: The v12 backport also checks for string here, in case flushes are not cached during a v12 patch update, see https://review.typo3.org/c/Packages/TYPO3.CMS/+/81806/1/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php#5782
  18. Sascha Nowak rebased onto patch set 7 CR +1 V +1 11/20/23, 16:43

  19. core-ci voted on patch set 7 V +1 11/20/23, 16:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49160

  20. Benjamin Franzke voted on patch set 7 V +1 CR +1 11/20/23, 18:47

  21. Christian Kuhn voted on patch set 7 V +1 CR +1 11/20/23, 21:11

  22. Benjamin Franzke voted on patch set 7 V +2 CR +2 11/20/23, 21:28

  23. Benjamin Franzke merged patch set 8 11/20/23, 21:28