Review main Merged

80529[TASK] Prepare SchemaMigrator towards DI

Christian Kuhn CR +2 V +2 Easy +3 −0 updated 08/12/23, 16:41

Commit message

The low level service SchemaMigrator is used in
ext:install and testing-framework.
To allow DI in SchemaMigrator, testing-framework
needs a pre-patch, which needs this pre-patch in
core.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Jasmina Ließmann +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Jasmina Ließmann +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1117

  1. Christian Kuhn uploaded patch set 1 08/12/23, 13:39

  2. core-ci voted on patch set 1 V -1 08/12/23, 13:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45408

  3. Christian Kuhn uploaded patch set 2 V -1 08/12/23, 13:52

  4. core-ci voted on patch set 2 V +1 08/12/23, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45410

  5. Christian Kuhn uploaded patch set 3 V +1 08/12/23, 14:01

  6. core-ci voted on patch set 3 V +1 08/12/23, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45411

  7. Christian Kuhn updated the commit message in patch set 4 V +1 08/12/23, 14:16

  8. Christian Kuhn voted on patch set 4 CR -1 08/12/23, 14:21

  9. core-ci voted on patch set 4 V +1 08/12/23, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45412

  10. Christian Kuhn uploaded patch set 5 CR -1 V +1 08/12/23, 14:27

  11. Christian Kuhn uploaded patch set 6 08/12/23, 14:27

  12. core-ci voted on patch set 5 V +1 08/12/23, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45415

  13. core-ci voted on patch set 6 V +1 08/12/23, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45416

  14. Jasmina Ließmann voted on patch set 6 V +1 CR +1 08/12/23, 15:20

  15. Stefan Bürk voted on patch set 6 V +1 CR +1 08/12/23, 16:39

  16. Stefan Bürk voted on patch set 6 V +2 CR +2 08/12/23, 16:41

  17. Stefan Bürk merged patch set 7 08/12/23, 16:41