Review main Merged

80530[TASK] Use DI in SchemaMigrator

Christian Kuhn CR +2 V +2 Hard +192 −243 updated 08/14/23, 10:11

Commit message

Core SchemaMigrator is the main entry point
of the "Database analyzer" and other DB
schema comparison and update functionality.

The class is used in low level scenarios
where the full container is not available.

The patch aims to have dependencies of
SchemaMigrator injected into the class, as
well as injecting SchemaMigrator into
consuming services. SchemaMigrator is used
in low level scenarios that have only the
failsafe container, we thus need to fiddle
with Services.php to configure injection.

The SchemaMigrator functional test is
refactored along the way, testing-framework
got a pre-patch and needs to be raised.

> composer u typo3/testing-framework

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 10

Review log 1014

  1. Christian Kuhn uploaded patch set 1 08/12/23, 13:39

  2. core-ci voted on patch set 1 V -1 08/12/23, 13:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45409

  3. Christian Kuhn uploaded patch set 2 V -1 08/14/23, 09:09

  4. core-ci voted on patch set 2 V +1 08/14/23, 09:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45470

  5. Christian Kuhn updated the commit message in patch set 3 V +1 08/14/23, 09:22

  6. core-ci voted on patch set 3 V +1 08/14/23, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45471

  7. Christian Kuhn updated the commit message in patch set 4 V +1 08/14/23, 09:30

  8. core-ci voted on patch set 4 V +1 08/14/23, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45472

  9. Oliver Klee voted on patch set 4 V +1 08/14/23, 09:39

  10. Oliver Klee voted on patch set 4 CR +1 08/14/23, 09:42

  11. Stefan Bürk voted on patch set 4 CR +1 08/14/23, 09:48

  12. Stefan Bürk voted on patch set 4 V +1 08/14/23, 09:57

  13. Christian Kuhn voted on patch set 4 V +2 CR +2 08/14/23, 10:11

  14. Christian Kuhn merged patch set 5 08/14/23, 10:11