Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

80535[WIP][BUGFIX] Ensure localizable sitemap entries

Guido Schmechel CR 0 V -1 Normal +45 −17 updated 04/21/26, 14:56

Commit message

Currently, sitemap page entries are always read out
based on the default language and then subsequently
read out with an overlay query. Language-specific
settings are ignored.

Now the pages are read out completely in the default language,
except for no_index entries. Afterwards, the pages are checked
for various criteria.

A follow-up patch could also add 1-2 PSR-14 events to be able
to intervene more in the sitemap handling. Or simply let the
developers completely overwrite the provider.

TODO:
- To clarify whether the approach is good enough
- Breaking change handling necessary as constants change?
- Tests

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/35/80535/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/35/80535/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Issues 1

Files 4

Review log 1013

  1. Guido Schmechel uploaded patch set 1 08/12/23, 20:06

  2. core-ci voted on patch set 1 V -1 08/12/23, 20:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45424

  3. Guido Schmechel uploaded patch set 2 V -1 08/12/23, 20:27

  4. core-ci voted on patch set 2 V +1 08/12/23, 20:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45425

  5. Benni Mack commented on patch set 2 12/11/24, 14:59

    hey guido, I think the approach is generally fine, but you cannot modify the TypoScript options in the bugfix change :)
  6. Guido Schmechel commented on patch set 2 12/11/24, 15:48

    Reply

    Is it then a task with breaking change handling?
  7. Benni Mack commented on patch set 2 12/11/24, 16:17

    Reply

    if we can avoid the breaking change, it's just a bugfix...
  8. Guido Schmechel commented on patch set 2 12/13/24, 20:41

    Reply

    I wanted to tidy things up a bit with the exclude. We can also leave the existing settings to prevent the breaking change. I can see these options: Option A: I add the two new settings excludeCanonical and excludeOverlayPages. That would be a task plus RST? Option B: We do without a setting and exclude these two new cases. That would be a bugfix. What do you think is better?
  9. Guido Schmechel uploaded patch set 3 V +1 01/19/25, 15:31

  10. core-ci voted on patch set 3 V -1 01/19/25, 15:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72682

  11. Benni Mack commented on patch set 3 04/11/25, 21:26

    Reply Unresolved

    Sorry for not answering earlier, Guido! Option A, I'd assume. One thing, I noticed though... while reading through the commit message. No one needs PSR-14 events in this code. The PageSitemapProvider is actually just one single implementation. If a project has problems with that one, just include your own and do it on your own. I think that's a valid point. side note: Pages MUST be handled like this that we always fetch the default language first, there is no way around unfortunately.
  12. Benni Mack marked it work in progress 04/21/26, 14:56

  13. Benni Mack wrote 04/21/26, 14:56

    Removed cc Benni Mack.