Review main Merged Breaking

80540[!!!][TASK] Disable external links by default in Linkvalidator

Sybille Peters CR +2 V +2 Normal +103 −3 updated 08/13/23, 18:50

Commit message

There are several known problems with external link checking
in Linkvalidator, specifically false positives and no
restriction / crawl limiting while checking links on
external sites.

These issues are currently not easily solvable and should
also be adressed specifically for the site concerned.

To make users aware of this problem, a page "Known problems"
was already added to the documentation in a previous patch
https://review.typo3.org/c/Packages/TYPO3.CMS/+/80421

We now deactivate checking "external" link types by
default in the configuration. The "external" link types
checking still works but must be enabled explicitly.

This will make users more aware of problem and the
specific problems can be adressed, e.g. by providing
a custom class to replace ExternalLinktype.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 5