Review main Abandoned

80547[WIP][BUGFIX] Use package key for static file registry

Andreas Kienast CR 0 V 0 Normal +70 −30 updated 04/01/25, 11:28

Commit message

This patch changes the behavior how data is stored in `sys_registry`
when importing static files on extension installation.

Previously, the path to the extension was calculcated in a flawed way
in Composer-mode as a non-Composer-mode was assumed. This especially
occurs when the document root directory is NOT `public`.

To solve this, the plain package key is now used instead of a calculated
path.

TODO:
* Add migration wizard

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 812

  1. Andreas Kienast uploaded patch set 1 08/14/23, 11:16

  2. core-ci voted on patch set 1 V +1 08/14/23, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45478

  3. Andreas Kienast uploaded patch set 2 V +1 08/14/23, 13:41

  4. core-ci voted on patch set 2 V +1 08/14/23, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45483

  5. Pierrick Caillon commented on patch set 2 CR -1 09/12/23, 07:59

    Identified an inconsistency in checked / defined keys.

    InstallUtility.php:306

    Isn't a colon missing like how it is looked up by registrationKeyExists?
  6. Andreas Kienast commented on patch set 3 CR -1 V +1 09/12/23, 08:27

    Published edit on patch set 2.
  7. Andreas Kienast commented on patch set 3 09/12/23, 08:27

    InstallUtility.php:306 Reply

    Ack. Good catch!
  8. core-ci voted on patch set 3 V +1 09/12/23, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46508

  9. Pierrick Caillon voted on patch set 3 CR +1 11/10/23, 10:25

  10. Andreas Kienast uploaded patch set 4 CR +1 V +1 01/12/24, 08:20

  11. core-ci voted on patch set 4 V +1 01/12/24, 08:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51482

  12. Andreas Kienast abandoned the change 04/01/25, 11:28