Review main Merged

80549[BUGFIX] Restore currently selected folder in ElementBrowser

Nikita Hovratov CR +2 V +2 Easy +3 −2 updated 08/16/23, 08:26

Commit message

Since the major refactoring of ElementBrowsers into the file list module
the order in which the currently selected folder from the user is loaded
got messed up. The retrieval of the folder was moved from the
render method to the initialization chain. However, at this point the
session data is not processed yet.

To fix this, the folder retrieval is moved back to the start of the
render method.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Thomas Hohn +1
    • Stefan Bürk +1
    • Jörg Bösche +1
    • Benni Mack +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 910

  1. Nikita Hovratov uploaded patch set 1 08/14/23, 17:12

  2. core-ci voted on patch set 1 V +1 08/14/23, 17:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45486

  3. Jörg Bösche voted on patch set 1 CR +1 08/14/23, 19:03

  4. Simon Schaufelberger commented on patch set 1 08/15/23, 03:50

    Jörg, can you fix your name please? something is wrong with the encoding.
  5. Oliver Klee commented on patch set 1 08/15/23, 08:24

    Reply

    AFAIK, that is a bug due related to the latest Gerrit update or the migration to the SAML-based SSO, and not something that individual users can fix. (Someone from the server team mentioned that somewhere, but I cannot find it right now anymore.)
  6. Thomas Hohn voted on patch set 1 CR +1 08/15/23, 09:11

  7. Benni Mack voted on patch set 1 V +1 CR +1 08/16/23, 08:11

  8. Stefan Bürk voted on patch set 1 V +1 CR +1 08/16/23, 08:25

  9. Nikita Hovratov voted on patch set 1 V +2 CR +2 08/16/23, 08:26

  10. Nikita Hovratov merged patch set 2 08/16/23, 08:26