Review main Abandoned

80552[BUGFIX] Fix classloader dump after extension install

Benjamin Franzke CR 0 V 0 Easy +2 −5 updated 08/15/23, 05:39

Commit message

With #101596 event listener registrations were migrated to
PHP attributes. Service registrations may only be performed
on non-static methods with symfony/dependency-injection <6.3 [1].
This caused the 'non-composer-class-loader' events to be silently
skipped, which is why no class loading information was dumped.
ClassLoadingInformation event listeners are changed to instance
methods to circumvent this bug in symfony/dependency-injection.

Also stray and unneeded Services.yaml configuration is removed.
(public: false is the default and does not need to be set at all)

[1] https://github.com/symfony/symfony/pull/47066

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2