Review main Merged

80555[TASK] Use correct method visibility in Lit elements

Andreas Kienast CR +2 V +2 Normal +117 −117 updated 08/16/23, 08:45

Commit message

The methods `createRenderRoot()` and `render()` are considered being
protected, but were public in some cases my mistake. This doesn't have
any functional impact, but is now fixed nonetheless.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 34

Show 14 more files

Review log 913

  1. Andreas Kienast uploaded patch set 1 08/15/23, 12:43

  2. core-ci voted on patch set 1 V +1 08/15/23, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45503

  3. Benni Mack commented on patch set 1 08/15/23, 13:14

    tbh, I think we should backport this to v12 in order to make life easier when fixing issues that also affect v12.
  4. Andreas Kienast updated the commit message in patch set 2 V +1 08/15/23, 14:10

  5. core-ci voted on patch set 2 V +1 08/15/23, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45507

  6. Benni Mack voted on patch set 2 V +1 CR +1 08/16/23, 08:09

  7. Benjamin Franzke uploaded patch set 3 CR +1 V +1 08/16/23, 08:23

  8. Benjamin Franzke updated the commit message in patch set 4 CR +1 V +1 08/16/23, 08:25

  9. Benni Mack voted on patch set 4 V +1 CR +1 08/16/23, 08:27

  10. Benjamin Franzke voted on patch set 4 V +2 CR +2 08/16/23, 08:29

  11. core-ci voted on patch set 3 V +1 08/16/23, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45534

  12. core-ci voted on patch set 4 V +1 08/16/23, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45536

  13. Benjamin Franzke merged patch set 5 08/16/23, 08:45