80556[TASK] Streamline top frame detection
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 99
- Build/Sources/TypeScript/backend/element/editable-page-title.ts+2 −1
- Build/Sources/TypeScript/backend/event/event-dispatcher.ts+4 −2
- Build/Sources/TypeScript/backend/live-search/result-types/default-result-type.ts+2 −1
- Build/Sources/TypeScript/backend/live-search/live-search-configurator.ts+3 −10
- Build/Sources/TypeScript/backend/page-tree/page-tree-element.ts+7 −5
- Build/Sources/TypeScript/backend/toolbar/live-search.ts+2 −8
- Build/Sources/TypeScript/backend/toolbar/shortcut-menu.ts+2 −5
- Build/Sources/TypeScript/backend/tree/file-storage-browser.ts+3 −2
- Build/Sources/TypeScript/backend/tree/file-storage-tree-container.ts+8 −6
- Build/Sources/TypeScript/backend/tree/page-browser.ts+2 −1
- Build/Sources/TypeScript/backend/utility/top-frame.ts1new+83 −0
- Build/Sources/TypeScript/backend/utility/top-level-module-import.ts+3 −1
- Build/Sources/TypeScript/backend/ajax-data-handler.ts+2 −1
- Build/Sources/TypeScript/backend/clipboard-panel.ts+3 −2
- Build/Sources/TypeScript/backend/context-menu-actions.ts+13 −12
- Build/Sources/TypeScript/backend/date-time-picker.ts+3 −2
- Build/Sources/TypeScript/backend/drag-uploader.ts+2 −1
- Build/Sources/TypeScript/backend/form-engine.ts+3 −4
- Build/Sources/TypeScript/backend/info-window.ts+4 −8
- Build/Sources/TypeScript/backend/login-refresh.ts+3 −33
Show 79 more files
- Build/Sources/TypeScript/backend/login.ts+3 −2
- Build/Sources/TypeScript/backend/modal.ts+7 −25
- Build/Sources/TypeScript/backend/module-menu.ts+7 −8
- Build/Sources/TypeScript/backend/multi-record-selection-edit-action.ts+2 −1
- Build/Sources/TypeScript/backend/multi-step-wizard.ts+11 −41
- Build/Sources/TypeScript/backend/notification.ts+2 −27
- Build/Sources/TypeScript/backend/online-media.ts+2 −1
- Build/Sources/TypeScript/backend/recordlist.ts+4 −3
- Build/Sources/TypeScript/backend/severity.ts+1 −31
- Build/Sources/TypeScript/backend/svg-tree.ts+3 −2
- Build/Sources/TypeScript/backend/switch-user.ts+3 −2
- Build/Sources/TypeScript/backend/viewport.ts+2 −9
- Build/Sources/TypeScript/backend/window-manager.ts+3 −13
- Build/Sources/TypeScript/backend/wizard.ts+7 −37
- Build/Sources/TypeScript/core/java-script-item-processor.ts+12 −1
- Build/Sources/TypeScript/extensionmanager/repository.ts+2 −1
- Build/Sources/TypeScript/filelist/context-menu-actions.ts+22 −19
- Build/Sources/TypeScript/filelist/file-delete.ts+4 −3
- Build/Sources/TypeScript/filelist/file-list-dragdrop.ts+3 −2
- Build/Sources/TypeScript/filelist/file-list-rename-handler.ts+2 −1
- Build/Sources/TypeScript/filelist/file-list-transfer-handler.ts+5 −4
- Build/Sources/TypeScript/filelist/file-list.ts+5 −4
- Build/Sources/TypeScript/form/backend/form-manager/view-model.ts+3 −2
- Build/Sources/TypeScript/impexp/context-menu-actions.ts+5 −3
- Build/Sources/TypeScript/install/installer.ts+2 −1
- Build/Sources/TypeScript/recycler/recycler.ts+2 −1
- Build/Sources/TypeScript/workspaces/toolbar/workspaces-menu.ts+2 −4
- Build/Sources/TypeScript/workspaces/backend.ts+10 −7
- Build/Sources/TypeScript/workspaces/preview.ts+3 −2
- Build/.eslintrc.json+20 −0
- typo3/sysext/backend/Resources/Public/JavaScript/element/editable-page-title.js+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/event/event-dispatcher.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/result-types/default-result-type.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/live-search-configurator.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/page-tree/page-tree-element.js+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/toolbar/live-search.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/toolbar/shortcut-menu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/tree/file-storage-browser.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/tree/file-storage-tree-container.js+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/tree/page-browser.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/utility/top-frame.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/utility/top-level-module-import.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ajax-data-handler.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/clipboard-panel.js+3 −3
- typo3/sysext/backend/Resources/Public/JavaScript/context-menu-actions.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/date-time-picker.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/drag-uploader.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/info-window.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/login-refresh.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/login.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/modal.js+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/module-menu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/multi-record-selection-edit-action.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/multi-step-wizard.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/notification.js+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/online-media.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/recordlist.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/severity.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/svg-tree.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/switch-user.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/viewport.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/window-manager.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/wizard.js+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/java-script-item-processor.js+1 −1
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/repository.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/context-menu-actions.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/file-delete.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/file-list-dragdrop.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/file-list-rename-handler.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/file-list-transfer-handler.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/file-list.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-manager/view-model.js+1 −1
- typo3/sysext/impexp/Resources/Public/JavaScript/context-menu-actions.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/installer.js+1 −1
- typo3/sysext/recycler/Resources/Public/JavaScript/recycler.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/toolbar/workspaces-menu.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/preview.js+1 −1
Review log 1727
Show 12 earlier messages
-
Benjamin Franzke uploaded patch set 1 08/15/23, 13:18
-
core-ci voted on patch set 1 V +1 08/15/23, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45504
-
Benjamin Franzke uploaded patch set 2
V +108/15/23, 19:08 -
Benjamin Franzke uploaded patch set 3 08/15/23, 19:08
-
core-ci voted on patch set 2 V -1 08/15/23, 19:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45519
-
core-ci voted on patch set 3 V +1 08/15/23, 19:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45520
-
Benjamin Franzke uploaded patch set 4
V +108/16/23, 05:35 -
core-ci voted on patch set 4 V +1 08/16/23, 05:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45529
-
Benjamin Franzke uploaded patch set 5
V +108/16/23, 08:17 -
core-ci voted on patch set 5 V +1 08/16/23, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45533
-
Benjamin Franzke uploaded patch set 6
V +108/16/23, 09:54 -
Benjamin Franzke uploaded patch set 7 08/16/23, 09:58
-
core-ci voted on patch set 6 V +1 08/16/23, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45542
-
core-ci voted on patch set 7 V +1 08/16/23, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45543
-
Benjamin Franzke uploaded patch set 8
V +108/16/23, 10:19 -
core-ci voted on patch set 8 V +1 08/16/23, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45544
-
Benjamin Kott rebased onto patch set 9
V +108/17/23, 12:58 -
core-ci voted on patch set 9 V +1 08/17/23, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45579
-
Benni Mack voted on patch set 9 V +1 CR +1 08/18/23, 07:29
-
Benjamin Franzke uploaded patch set 10
CR +1V +108/28/23, 16:00Rebase -
core-ci voted on patch set 10 V +1 08/28/23, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45925
-
Christian Kuhn voted on patch set 10 V +1 CR +1 08/28/23, 17:49
-
Andreas Kienast commented on patch set 10 08/29/23, 08:25
top-frame.ts:22UnresolvedIf possible, I'd rather check the window name which is hardcoded to `typo3-backend`. -
Benjamin Franzke commented on patch set 10 CR -1 08/29/23, 08:37
on hold, not actually needed for playwright -
Benjamin Franzke marked it work in progress 08/29/23, 08:37
-
Benni Mack updated the commit message in patch set 11
CR +1V +110/18/24, 14:11 -
Benjamin Franzke abandoned the change 03/05/25, 03:53
not needed for playwright and we're not going to use cypress. Also feels wrong to build an abstraction for a broken concept. Will rather concentrate on reducing globals.