Review main Abandoned

80556[TASK] Streamline top frame detection

Benjamin Franzke CR 0 V 0 Hard +381 −417 updated 03/05/25, 03:53

Commit message

Move top frame detection into a utility module
that exposes the top TYPO3 and window object
and provides a helper method for cross-frame
shared instance registrations.

This is to ensure we never use top.* directly without
checking whether that's a TYPO3 instance, which is
required for acceptance testing frameworkes like
cypress or playwright which render the testcase in an
iframe.

The eslint rules are adapted to deny use of
`top` or `window.top` from now on.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 99

Show 79 more files

Review log 1727

Show 12 earlier messages
  1. Benjamin Franzke uploaded patch set 1 08/15/23, 13:18

  2. core-ci voted on patch set 1 V +1 08/15/23, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45504

  1. Benjamin Franzke uploaded patch set 2 V +1 08/15/23, 19:08

  2. Benjamin Franzke uploaded patch set 3 08/15/23, 19:08

  3. core-ci voted on patch set 2 V -1 08/15/23, 19:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45519

  4. core-ci voted on patch set 3 V +1 08/15/23, 19:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45520

  5. Benjamin Franzke uploaded patch set 4 V +1 08/16/23, 05:35

  6. core-ci voted on patch set 4 V +1 08/16/23, 05:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45529

  7. Benjamin Franzke uploaded patch set 5 V +1 08/16/23, 08:17

  8. core-ci voted on patch set 5 V +1 08/16/23, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45533

  9. Benjamin Franzke uploaded patch set 6 V +1 08/16/23, 09:54

  10. Benjamin Franzke uploaded patch set 7 08/16/23, 09:58

  11. core-ci voted on patch set 6 V +1 08/16/23, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45542

  12. core-ci voted on patch set 7 V +1 08/16/23, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45543

  13. Benjamin Franzke uploaded patch set 8 V +1 08/16/23, 10:19

  14. core-ci voted on patch set 8 V +1 08/16/23, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45544

  15. Benjamin Kott rebased onto patch set 9 V +1 08/17/23, 12:58

  16. core-ci voted on patch set 9 V +1 08/17/23, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45579

  17. Benni Mack voted on patch set 9 V +1 CR +1 08/18/23, 07:29

  18. Benjamin Franzke uploaded patch set 10 CR +1 V +1 08/28/23, 16:00

    Rebase
  19. core-ci voted on patch set 10 V +1 08/28/23, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45925

  20. Christian Kuhn voted on patch set 10 V +1 CR +1 08/28/23, 17:49

  21. Andreas Kienast commented on patch set 10 08/29/23, 08:25

    top-frame.ts:22 Unresolved

    If possible, I'd rather check the window name which is hardcoded to `typo3-backend`.
  22. Benjamin Franzke commented on patch set 10 CR -1 08/29/23, 08:37

    on hold, not actually needed for playwright
  23. Benjamin Franzke marked it work in progress 08/29/23, 08:37

  24. Benni Mack updated the commit message in patch set 11 CR +1 V +1 10/18/24, 14:11

  25. Benjamin Franzke abandoned the change 03/05/25, 03:53

    not needed for playwright and we're not going to use cypress. Also feels wrong to build an abstraction for a broken concept. Will rather concentrate on reducing globals.