Review main Merged

80558[DOCS] Fix code examples for tagging event listeners with PHP attribute

Chris Müller CR +2 V +2 Normal +39 −20 updated 08/16/23, 08:58

Commit message

The "event" value in the PHP attribute has to be the FQCN of the event
class. Additionally, a caption is added to the PHP examples and some
wording has been adjusted.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 57

  1. Chris Müller uploaded patch set 1 08/15/23, 17:26

  2. Chris Müller updated the commit message in patch set 2 08/15/23, 17:27

  3. core-ci voted on patch set 1 V +1 08/15/23, 17:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45515

  4. core-ci voted on patch set 2 V +1 08/15/23, 17:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45516

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 08/16/23, 07:55

  6. Benjamin Franzke voted on patch set 2 V +2 CR +2 08/16/23, 08:58

  7. Benjamin Franzke merged patch set 3 08/16/23, 08:58