Review 12.4 Merged

80559[TASK] Do not use to-be deprecated `unload` event

Benjamin Franzke CR +2 V +2 Easy +12 −14 updated 08/16/23, 08:10

Commit message

Google Chrome (and other browser vendors will probably follow)
deprecates the unload event with Chrome 117 [1] and encourages using
the Page Lifecycle API [2] instead. This patch replaces any usage of
the `unload` event with the `pagehide` event that is available for all
supported browsers [3].

[1] https://developer.chrome.com/en/blog/deprecating-unload/
[2] https://developer.chrome.com/blog/page-lifecycle-api/
[3] https://caniuse.com/mdn-api_window_pagehide_event

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 6

Review log 23

  1. Benjamin Franzke uploaded patch set 1 08/16/23, 07:56

  2. core-ci voted on patch set 1 V +1 08/16/23, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45531

  3. Benjamin Franzke merged patch set 2 08/16/23, 08:10