Review 11.5 Merged

80560[TASK] Do not use to-be deprecated `unload` event

Benjamin Franzke CR +2 V +2 Easy +12 −14 updated 08/16/23, 08:11

Commit message

Google Chrome (and other browser vendors will probably follow)
deprecates the unload event with Chrome 117 [1] and encourages using
the Page Lifecycle API [2] instead. This patch replaces any usage of
the `unload` event with the `pagehide` event that is available for all
supported browsers [3].

[1] https://developer.chrome.com/en/blog/deprecating-unload/
[2] https://developer.chrome.com/blog/page-lifecycle-api/
[3] https://caniuse.com/mdn-api_window_pagehide_event

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5