Review 12.4 Merged

80561[TASK] Use correct method visibility in Lit elements

Benjamin Franzke CR +2 V +2 Normal +109 −109 updated 08/16/23, 08:46

Commit message

The methods `createRenderRoot()` and `render()` are considered being
protected, but were public in some cases my mistake. This doesn't have
any functional impact, but is now fixed nonetheless.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 30

Show 10 more files

Review log 45

  1. Benjamin Franzke uploaded patch set 1 08/16/23, 08:29

  2. Benjamin Franzke voted on patch set 1 V 0 CR -1 08/16/23, 08:31

  3. Benjamin Franzke uploaded patch set 2 CR -1 08/16/23, 08:37

  4. core-ci voted on patch set 2 V +1 08/16/23, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45538

  5. Benjamin Franzke merged patch set 3 08/16/23, 08:46