Review main Merged

80562[TASK] Deny global jQuery usage via eslint rules

Benjamin Franzke CR +2 V +2 Hard +25 −290 updated 08/29/23, 09:40

Commit message

This allows to drop a npm patch that had been applied
to the TypeScript @types/jquery before, in order
to achieve the same effect.
With eslint we can additionally provide a good
hint for the developer, what to use instead.

Commands executed:
  npm remove patch-package
  npm install

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 812

  1. Benjamin Franzke uploaded patch set 1 08/16/23, 10:19

  2. core-ci voted on patch set 1 V -1 08/16/23, 10:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45545

  3. Benjamin Franzke uploaded patch set 2 V -1 08/16/23, 10:55

  4. core-ci voted on patch set 2 V +1 08/16/23, 11:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45547

  5. Benjamin Franzke rebased onto patch set 3 V +1 08/28/23, 18:11

  6. core-ci voted on patch set 3 V +1 08/28/23, 18:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45936

  7. Benjamin Franzke uploaded patch set 4 V +1 08/29/23, 08:43

  8. core-ci voted on patch set 4 V +1 08/29/23, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45955

  9. Andreas Kienast voted on patch set 4 V +1 CR +1 08/29/23, 09:19

  10. Christian Kuhn voted on patch set 4 V +1 CR +1 08/29/23, 09:33

  11. Benjamin Franzke voted on patch set 4 V +2 CR +2 08/29/23, 09:40

  12. Benjamin Franzke merged patch set 5 08/29/23, 09:40