Review main Merged

80568[TASK] Replace `php -S` with apache2 and php-fpm

Stefan Bürk CR +2 V +2 Normal +154 −36 updated 09/07/23, 10:38

Commit message

This change uses a slighty modified httpd (apache2)
image based on alpine along with a own php-fpm image
to spawn up a webserver with php-fpm in two containers
as a replacement for the `php -S` webserver used prior.

Modification for the apache2 (httpd) image are minimal
and gives us the ability to mount the project with the
exact same path in the image as from outside. Further
all required apache2 modules are loaded missing the
official image.

Due to moving away from the php webserver we now need
to adjust some configurations:

* Use port 80 instead of 8000 the for acceptance
  and acceptanceInstall tests webserver.
* Use the acceptance test instance as DocumentRoot
  instead of the monorepo root.
* Copy several `.htaccess` files to the acceptance
  test instance as we now have a real apache2.
* Copy the favicon.ico to the test instance instead
  of the monorepo root.
* Ensure that created frontend SiteConfiguration no
  longer uses the relative test instance path.
  Simply use `/`.
* Use only the php-fpm image for cli and webserver
  fpm container.

Used command(s):

> composer u "typo3/testing-framework"

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 3467

Show 2042 earlier messages
  1. Stefan Bürk uploaded patch set 1 08/17/23, 12:59

  2. core-ci voted on patch set 1 V +1 08/17/23, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45581

  3. Stefan Bürk uploaded patch set 2 V +1 08/17/23, 15:41

  4. core-ci voted on patch set 2 V +1 08/17/23, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45586

  5. Stefan Bürk uploaded patch set 3 V +1 08/18/23, 12:00

  6. core-ci voted on patch set 3 V +1 08/18/23, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45602

  7. Stefan Bürk uploaded patch set 4 V +1 08/18/23, 13:08

  8. core-ci voted on patch set 4 V +1 08/18/23, 13:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45603

  9. Stefan Bürk uploaded patch set 5 V +1 08/18/23, 16:01

  10. core-ci voted on patch set 5 V +1 08/18/23, 16:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45609

  11. Stefan Bürk updated the commit message in patch set 6 V +1 08/22/23, 05:44

  12. core-ci voted on patch set 6 V +1 08/22/23, 05:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45661

  13. Stefan Bürk uploaded patch set 7 V +1 08/23/23, 13:32

  14. core-ci voted on patch set 7 V -1 08/23/23, 13:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45750

  15. Stefan Bürk uploaded patch set 8 V -1 08/29/23, 10:07

  16. core-ci voted on patch set 8 V -1 08/29/23, 10:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45969

  17. Stefan Bürk uploaded patch set 9 V -1 08/29/23, 12:56

  18. core-ci voted on patch set 9 V -1 08/29/23, 13:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45981

  19. Stefan Bürk uploaded patch set 10 V -1 08/29/23, 14:48

  20. core-ci voted on patch set 10 V -1 08/29/23, 15:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45986

  21. Stefan Bürk uploaded patch set 11 V -1 08/29/23, 16:02

  22. core-ci voted on patch set 11 V -1 08/29/23, 16:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45989

  23. Stefan Bürk uploaded patch set 12 V -1 08/29/23, 18:54

  24. core-ci voted on patch set 12 V -1 08/29/23, 19:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45993

  25. Stefan Bürk uploaded patch set 13 V -1 08/29/23, 19:18

  26. core-ci voted on patch set 13 V -1 08/29/23, 19:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45994

  27. Stefan Bürk uploaded patch set 14 V -1 08/29/23, 20:08

  28. core-ci voted on patch set 14 V +1 08/29/23, 20:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45996

  29. Stefan Bürk uploaded patch set 15 V +1 08/29/23, 20:20

  30. core-ci voted on patch set 15 V +1 08/29/23, 20:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45997

  31. Stefan Bürk uploaded patch set 16 V +1 08/29/23, 20:49

  32. core-ci voted on patch set 16 V -1 08/29/23, 21:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45998

  33. Stefan Bürk uploaded patch set 17 V -1 08/30/23, 08:01

  34. core-ci voted on patch set 17 V -1 08/30/23, 08:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46018

  35. Stefan Bürk uploaded patch set 18 V -1 08/30/23, 08:16

  36. core-ci voted on patch set 18 V -1 08/30/23, 08:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46019

  37. Stefan Bürk uploaded patch set 19 V -1 08/30/23, 08:43

  38. core-ci voted on patch set 19 V +1 08/30/23, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46021

  39. core-ci voted on patch set 19 V -1 08/30/23, 09:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46023

  40. Stefan Bürk uploaded patch set 20 V -1 08/31/23, 17:05

  41. core-ci voted on patch set 20 V +1 08/31/23, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46111

  42. core-ci voted on patch set 20 V -1 08/31/23, 17:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46112

  1. Stefan Bürk uploaded patch set 21 V -1 08/31/23, 17:36

  2. core-ci voted on patch set 21 V +1 08/31/23, 17:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46113

  3. core-ci voted on patch set 21 V -1 08/31/23, 18:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46114

  4. Stefan Bürk uploaded patch set 22 V -1 08/31/23, 18:33

  5. core-ci voted on patch set 22 V -1 08/31/23, 18:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46116

  6. Stefan Bürk uploaded patch set 23 V -1 08/31/23, 19:01

  7. core-ci voted on patch set 23 V -1 08/31/23, 19:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46118

  8. Stefan Bürk uploaded patch set 24 V -1 09/01/23, 11:22

  9. core-ci voted on patch set 24 V +1 09/01/23, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46129

  10. Stefan Bürk uploaded patch set 25 V +1 09/01/23, 12:26

  11. core-ci voted on patch set 25 V +1 09/01/23, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46130

  12. core-ci commented on patch set 25 09/01/23, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46132

  13. Stefan Bürk uploaded patch set 26 V +1 09/01/23, 14:25

  14. core-ci voted on patch set 26 V +1 09/01/23, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46145

  15. core-ci commented on patch set 26 09/01/23, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46146

  16. Stefan Bürk uploaded patch set 27 V +1 09/01/23, 16:39

  17. core-ci voted on patch set 27 V +1 09/01/23, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46155

  18. Stefan Bürk updated the commit message in patch set 28 V +1 09/01/23, 16:50

  19. Stefan Bürk updated the commit message in patch set 29 09/01/23, 16:51

  20. core-ci voted on patch set 29 V +1 09/01/23, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46157

  21. Christian Kuhn voted on patch set 29 V +1 CR +1 09/01/23, 17:08

  22. Christian Kuhn commented on patch set 29 09/01/23, 17:09

    please merge: this is "test only" ... if something goes wrong, stefan will adjust.
  23. Stefan Bürk commented on patch set 29 V +2 CR +2 09/01/23, 17:10

    Reply

    Merge as "test & main only".
  24. Stefan Bürk merged patch set 30 09/01/23, 17:10

  25. Stefan Bürk commented on patch set 30 09/07/23, 10:38

    Backporting it late to 12.4 as we need it there too.