80593[BUGFIX] Copied content element inherits all language
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 1216
-
Łukasz Uznański uploaded patch set 1 08/17/23, 18:56
-
core-ci voted on patch set 1 V +1 08/17/23, 19:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45590
-
Oliver Klee commented on patch set 1 08/17/23, 19:40
Can we please cover this with (functional) tests? -
Łukasz Uznański commented on patch set 1 08/18/23, 09:19
Reply
I will add functional test to cover this, but I would like to know your opinion about this approach, because there are a lot of ways to solve this and I'm not sure If I picked best one. -
Benni Mack commented on patch set 1 08/18/23, 10:54
Reply
how about we set the languageField in the fieldArry explicitly to "-1"? -
Oliver Klee commented on patch set 1 08/18/23, 11:07
Reply
Unfortunately, I cannot comment on whether this approach is the right one - I don't know enough of the inner workings of the `DataHandler` for this. We need someone with more knowledge of this class for this. -
Łukasz Uznański commented on patch set 1 08/18/23, 11:57
Reply Unresolved
I can set this value explicitly to "-1" but in this scenario, we will update this record with the same value, or I can set it somewhere above in this method, and then this field will be automatically omitted. I think this might be a better idea than unsetting it directly. I will provide test case first, and then try to modify this behavior. -
Łukasz Uznański uploaded patch set 2
V +108/18/23, 13:55 -
core-ci voted on patch set 2 V -1 08/18/23, 14:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45605
-
Łukasz Uznański uploaded patch set 3
V -108/18/23, 14:06 -
core-ci voted on patch set 3 V +1 08/18/23, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45606
-
Oliver Klee wrote 08/25/24, 10:13
Removed cc Oliver Klee. -
Łukasz Uznański updated the commit message in patch set 4
V +108/26/24, 10:31 -
core-ci voted on patch set 4 V -1 08/26/24, 14:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64195
-
Christian Kuhn commented on patch set 4 01/09/25, 17:01
see related change https://review.typo3.org/c/Packages/TYPO3.CMS/+/86773: i'm not yet fully convinced this also fixes it for -1 records, but it may be. -
Benni Mack abandoned the change 04/11/25, 20:53
Abandoning this change... because this alternative approach here fixes the actual problem https://review.typo3.org/c/Packages/TYPO3.CMS/+/89068 and due to lack of feedback here