Review main Merged

80597[BUGFIX] Apply typolink.forceAbsoluteUrl to absolute path URIs

Oliver Hader CR +2 V +2 Easy +25 −0 updated 08/23/23, 21:18

Commit message

Due to #101083 absolute path URIs like `/path/some-file.png`
are handled as external URL, which leads to scenarios, that
the fully qualified domain name is not applied anymore, when
using `typolink.forceAbsoluteUrl=1`.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1013

  1. Oliver Hader uploaded patch set 1 08/18/23, 13:47

  2. Benni Mack voted on patch set 1 CR +1 08/18/23, 13:50

  3. core-ci voted on patch set 1 V -1 08/18/23, 13:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45604

  4. Oliver Hader uploaded patch set 2 CR +1 V -1 08/18/23, 14:47

  5. core-ci voted on patch set 2 V +1 08/18/23, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45608

  6. Benni Mack voted on patch set 2 V +1 CR +1 08/18/23, 15:04

  7. Jörg Bösche voted on patch set 2 CR +1 08/22/23, 11:57

  8. Christian Kuhn updated the commit message in patch set 3 CR +1 V +1 08/22/23, 12:31

  9. core-ci voted on patch set 3 V +1 08/22/23, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45675

  10. Benni Mack voted on patch set 3 V +1 CR +1 08/23/23, 18:49

  11. Christian Kuhn voted on patch set 3 V +1 CR +1 08/23/23, 18:49

  12. Oliver Hader voted on patch set 3 V +2 CR +2 08/23/23, 21:17

  13. Oliver Hader merged patch set 4 08/23/23, 21:18